Issue 7381046: code review 7381046: regexp: use Scanner in exec_test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7381046: code review 7381046: regexp: use Scanner in exec_test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by r

Modified:
12 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r 581adbae728e https://code.google.com/p/go #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -11 lines)			Patch
	M	src/pkg/regexp/exec_test.go	View	1	3 chunks	+6 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years ago (2013-02-20 21:28:04 UTC) #1

rsc

LGTM https://codereview.appspot.com/7381046/diff/1/src/pkg/regexp/exec_test.go File src/pkg/regexp/exec_test.go (right): https://codereview.appspot.com/7381046/diff/1/src/pkg/regexp/exec_test.go#newcode199 src/pkg/regexp/exec_test.go:199: if scanner.Err() != nil { if err := ...

12 years ago (2013-02-20 21:34:56 UTC) #2

12 years ago (2013-02-20 21:37:49 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=1a601215e0dc ***

regexp: use Scanner in exec_test

R=rsc
CC=golang-dev
https://codereview.appspot.com/7381046

Expand All Messages | Collapse All Messages