Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(646)

Issue 7380047: environs/ec2: try to get tests working on raring (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by dave
Modified:
11 years, 1 month ago
Reviewers:
mp+150254
Visibility:
Public.

Description

environs/ec2: try to get tests working on raring Add fixtures for raring https://code.launchpad.net/~dave-cheney/juju-core/097-environs-raring-fixtures/+merge/150254 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/ec2: try to get tests working on raring #

Patch Set 3 : environs/ec2: try to get tests working on raring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
A environs/ec2/testdata/query/raring/server/released.current.txt View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 7
dave_cheney.net
Please take a look.
11 years, 2 months ago (2013-02-25 00:48:50 UTC) #1
jameinel
LGTM trivial
11 years, 2 months ago (2013-02-27 13:33:21 UTC) #2
dave_cheney.net
Sadly it doesn't fix all of thumpers problems, which I can't replicate on Quantal and ...
11 years, 2 months ago (2013-02-27 23:02:02 UTC) #3
thumper
LGTM - can't hurt, right?
11 years, 2 months ago (2013-02-28 04:08:03 UTC) #4
dave_cheney.net
Ok, will submit as it, you *do* need these fixtures. On 28/02/2013, at 15:08, tim.penhey@canonical.com ...
11 years, 2 months ago (2013-02-28 04:13:52 UTC) #5
dave_cheney.net
Please take a look.
11 years, 2 months ago (2013-03-04 16:33:07 UTC) #6
dave_cheney.net
11 years, 2 months ago (2013-03-04 16:34:17 UTC) #7
*** Submitted:

environs/ec2: try to get tests working on raring

Add fixtures for raring

R=jameinel, thumper
CC=
https://codereview.appspot.com/7380047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b