Issue 7379051: code review 7379051: syscall, runtime: Plan 9: use nanotime syscall on amd64

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7379051: code review 7379051: syscall, runtime: Plan 9: use nanotime syscall on amd64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by akumar

Modified:
12 years, 3 months ago

Reviewers:

CC:
rsc, rminnich, ality, golang-dev

Visibility:
Public.

Description

syscall, runtime: Plan 9: use nanotime syscall on amd64 Separates the implementation of nanotime on 64-bit version of Plan 9 from that on the 32-bit version. The former uses a syscall.

Patch Set 1 #

Patch Set 2 : diff -r 8e4103edc064 https://code.google.com/p/go #

Patch Set 3 : diff -r fb4e43176b32 https://code.google.com/p/go #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -47 lines)			Patch
M	src/pkg/runtime/sys_plan9_amd64.s	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/thread_plan9.c	View	1	1 chunk	+0 lines, -28 lines	0 comments	Download
A	src/pkg/runtime/time_plan9_386.c	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_plan9.go	View	1	1 chunk	+2 lines, -19 lines	0 comments	Download
M	src/pkg/syscall/syscall_plan9_386.go	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_plan9_amd64.go	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsysnum_plan9_amd64.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

akumar

Hello rsc@golang.org, rminnich@gmail.com, ality@pbrane.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2013-02-26 00:42:18 UTC) #1

rminnich

12 years, 3 months ago (2013-02-26 00:56:11 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=fd4d555bf27d ***

syscall, runtime: Plan 9: use nanotime syscall on amd64

Separates the implementation of nanotime on 64-bit
version of Plan 9 from that on the 32-bit version.
The former uses a syscall.

R=rsc, rminnich, ality
CC=golang-dev
https://codereview.appspot.com/7379051

Committer: Ron Minnich <rminnich@gmail.com>

Expand All Messages | Collapse All Messages