Issue 7379050: Add and use a log_hook context manager.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7379050: Add and use a log_hook context manager.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by frankban

Modified:
11 years, 2 months ago

Reviewers:
mp+150413, gary.poster

Visibility:
Public.

Description

Add and use a log_hook context manager. Replace the current calls to log_entry and log_exit in the __main__ of the hooks with a log_hook context manager, simplifying the code a bit. Avoiding log_entry and log_exit also temporarily works around a problem they have with the juju-core handling of strings starting with "--" in juju-log. https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1132905-log-hook/+merge/150413 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add and use a log_hook context manager. #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -41 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	hooks/config-changed	View	3 chunks	+2 lines, -11 lines	0 comments	Download
M	hooks/install	View	4 chunks	+4 lines, -14 lines	0 comments	Download
M	hooks/start	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	hooks/stop	View	2 chunks	+6 lines, -10 lines	0 comments	Download
M	hooks/utils.py	View	4 chunks	+23 lines, -0 lines	0 comments	Download
M	tests/test_utils.py	View	3 chunks	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gary.poster

LGTM. Nice tests. Thanks! https://codereview.appspot.com/7379050/diff/1/hooks/config-changed File hooks/config-changed (right): https://codereview.appspot.com/7379050/diff/1/hooks/config-changed#newcode135 hooks/config-changed:135: with log_hook(): Nice!

11 years, 2 months ago (2013-02-25 23:37:21 UTC) #2

frankban

11 years, 2 months ago (2013-02-26 09:32:48 UTC) #3

*** Submitted:

Add and use a log_hook context manager.

Replace the current calls to log_entry and log_exit in the __main__ of
the hooks with a log_hook context manager, simplifying the code a bit.

Avoiding log_entry and log_exit also temporarily works around a problem
they have with the juju-core handling of strings starting with "--" in
juju-log.

R=gary.poster
CC=
https://codereview.appspot.com/7379050

Expand All Messages | Collapse All Messages