Issue 73790043: Fix some simplestreams tests for gccgo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 73790043: Fix some simplestreams tests for gccgo (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by wallyworld

Modified:
10 years, 1 month ago

Reviewers:
mp+210324, jameinel

Visibility:
Public.

Description

Fix some simplestreams tests for gccgo Order simplestreams fetch results so tests pass on gccgo. https://code.launchpad.net/~wallyworld/juju-core/simplestreams-ordering/+merge/210324 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -20 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/imagemetadata/generate_test.go	View	3 chunks	+4 lines, -12 lines	0 comments	Download
M	environs/imagemetadata/simplestreams.go	View	2 chunks	+14 lines, -0 lines	2 comments	Download
M	environs/imagemetadata/simplestreams_test.go	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	environs/tools/simplestreams.go	View	3 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jameinel

LGTM It seems like we should actually depend on the metadata requests returning sorted data, ...

10 years, 1 month ago (2014-03-11 11:32:40 UTC) #2

wallyworld

10 years, 1 month ago (2014-03-12 00:17:11 UTC) #3

https://codereview.appspot.com/73790043/diff/1/environs/imagemetadata/simples...
File environs/imagemetadata/simplestreams.go (right):

https://codereview.appspot.com/73790043/diff/1/environs/imagemetadata/simples...
environs/imagemetadata/simplestreams.go:185: Sort(metadata)
On 2014/03/11 11:32:40, jameinel wrote:
> It seems odd that we would need to sort by default, rather than just sorting
at
> the right time in tests.
> 
> Is the sort useful in general? (Does it give us any other benefit?)
> 
> I can live with it as a massive shotgun to fix gccgo issues, but it would be
> nice to understand why it is necessary. Perhaps a comment here?

I think it's nice to have stuff sorted, makes it easier to work out things when
looking at the data, and it costs almost nothing to do it. I'll add a comment.

Also, one of the sorts in the tests in not needed if we put a sort here. So I've
removed that one.

Expand All Messages | Collapse All Messages