Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(280)

Issue 7378066: uniter: split tests in smaller chunks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by dimitern
Modified:
11 years, 2 months ago
Reviewers:
mp+150368
Visibility:
Public.

Description

uniter: split tests in smaller chunks This is a trivial change, splitting the existing uniter tests into smaller logical chunks, which make it easier to invoke separately skip and debug. https://code.launchpad.net/~dimitern/juju-core/003-split-uniter-tests/+merge/150368 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : uniter: split tests in smaller chunks #

Patch Set 3 : uniter: split tests in smaller chunks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -45 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M worker/uniter/uniter_test.go View 1 15 chunks +119 lines, -45 lines 0 comments Download

Messages

Total messages: 6
dimitern
Please take a look.
11 years, 2 months ago (2013-02-25 16:54:36 UTC) #1
fwereade
LGTM. Do they get any faster, out of interest?
11 years, 2 months ago (2013-02-25 16:56:22 UTC) #2
dimitern
Please take a look.
11 years, 2 months ago (2013-02-25 16:56:38 UTC) #3
dimitern
On 2013/02/25 16:56:22, fwereade wrote: > LGTM. Do they get any faster, out of interest? ...
11 years, 2 months ago (2013-02-25 17:03:12 UTC) #4
TheMue
LGTM
11 years, 2 months ago (2013-02-25 17:08:03 UTC) #5
dimitern
11 years, 2 months ago (2013-02-25 17:13:19 UTC) #6
*** Submitted:

uniter: split tests in smaller chunks

This is a trivial change, splitting the existing
uniter tests into smaller logical chunks, which
make it easier to invoke separately skip and debug.

R=fwereade, TheMue
CC=
https://codereview.appspot.com/7378066
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b