Issue 7378057: code review 7378057: exp/ssa: support variadic synthetic methods.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7378057: code review 7378057: exp/ssa: support variadic synthetic methods. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by adonovan

Modified:
12 years, 3 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

exp/ssa: support variadic synthetic methods. We wrap the final '...' argument's type in types.Slice. Added tests. Also: - Function.writeSignature: suppress slice '[]' when printing variadic arg '...'. - Eliminate Package.ImportPath field; redundant w.r.t. Package.Types.Path. - Use "TODO: (opt|fix)" notation more widely. - Eliminate many redundant/stale TODOs.

Patch Set 1 #

Patch Set 2 : diff -r ebebb95cff06 https://code.google.com/p/go/ #

Patch Set 3 : diff -r ebebb95cff06 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 51f7d979c6e8 https://code.google.com/p/go/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -57 lines)			Patch
M	src/pkg/exp/ssa/blockopt.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/ssa/builder.go	View	1	12 chunks	+15 lines, -18 lines	0 comments	Download
M	src/pkg/exp/ssa/doc.go	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/pkg/exp/ssa/emit.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/ssa/func.go	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/pkg/exp/ssa/interp/reflect.go	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/pkg/exp/ssa/interp/testdata/coverage.go	View	1	2 chunks	+43 lines, -0 lines	0 comments	Download
M	src/pkg/exp/ssa/lift.go	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	src/pkg/exp/ssa/literal.go	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/pkg/exp/ssa/lvalue.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/exp/ssa/print.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/exp/ssa/promote.go	View	1	4 chunks	+12 lines, -6 lines	0 comments	Download
M	src/pkg/exp/ssa/ssa.go	View	1	2 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 3 months ago (2013-02-22 19:22:14 UTC) #1

adonovan

12 years, 3 months ago (2013-02-22 19:30:46 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=365c7549ba99 ***

exp/ssa: support variadic synthetic methods.

We wrap the final '...' argument's type in types.Slice.
Added tests.

Also:
- Function.writeSignature: suppress slice '[]' when printing
  variadic arg '...'.
- Eliminate Package.ImportPath field; redundant
  w.r.t. Package.Types.Path.
- Use "TODO: (opt|fix)" notation more widely.
- Eliminate many redundant/stale TODOs.

R=gri
CC=golang-dev
https://codereview.appspot.com/7378057

Expand All Messages | Collapse All Messages