Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(257)

Issue 7377052: code review 7377052: cmd/vet: move the tests into separate files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by r
Modified:
12 years, 3 months ago
Reviewers:
CC:
golang-dev, adg
Visibility:
Public.

Description

cmd/vet: move the tests into separate files Then mark them with a build tag so they're not compiled into the binary. They are called test_*.go rather than *_test.go because they are not for go test. Use make test to test the command.

Patch Set 1 #

Patch Set 2 : diff -r 06510582fad7 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -271 lines) Patch
M src/cmd/vet/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/vet/atomic.go View 2 chunks +0 lines, -31 lines 0 comments Download
M src/cmd/vet/buildtag.go View 1 chunk +0 lines, -5 lines 0 comments Download
M src/cmd/vet/method.go View 1 chunk +0 lines, -7 lines 0 comments Download
M src/cmd/vet/print.go View 2 chunks +0 lines, -135 lines 0 comments Download
R src/cmd/vet/print_unsafe.go View 1 chunk +0 lines, -19 lines 0 comments Download
M src/cmd/vet/rangeloop.go View 1 chunk +0 lines, -52 lines 0 comments Download
M src/cmd/vet/structtag.go View 1 chunk +0 lines, -4 lines 0 comments Download
M src/cmd/vet/taglit.go View 2 chunks +0 lines, -17 lines 0 comments Download
A src/cmd/vet/test_atomic.go View 1 chunk +43 lines, -0 lines 0 comments Download
A src/cmd/vet/test_buildtag.go View 1 chunk +15 lines, -0 lines 0 comments Download
A src/cmd/vet/test_method.go View 1 chunk +24 lines, -0 lines 0 comments Download
A src/cmd/vet/test_print.go View 1 chunk +153 lines, -0 lines 0 comments Download
A src/cmd/vet/test_rangeloop.go View 1 chunk +61 lines, -0 lines 0 comments Download
A src/cmd/vet/test_structtag.go View 1 chunk +15 lines, -0 lines 0 comments Download
A src/cmd/vet/test_taglit.go View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years, 3 months ago (2013-02-25 19:07:11 UTC) #1
adg
LGTM
12 years, 3 months ago (2013-02-25 22:05:47 UTC) #2
r
12 years, 3 months ago (2013-02-26 00:25:41 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=727762d74b81 ***

cmd/vet: move the tests into separate files
Then mark them with a build tag so they're not compiled into the binary.
They are called test_*.go rather than *_test.go because they are not
for go test. Use make test to test the command.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/7377052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b