code review 7376055: go/types: embedded fields can be predeclared types

go/types: embedded fields can be predeclared types

[gri, 2013-02-25 23:18:34]

Hello adonovan@google.com, r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[adonovan, 2013-02-26 04:34:27]

LGTM

https://codereview.appspot.com/7376055/diff/7001/src/pkg/go/types/operand.go
File src/pkg/go/types/operand.go (right):

https://codereview.appspot.com/7376055/diff/7001/src/pkg/go/types/operand.go#...
src/pkg/go/types/operand.go:303: // Ignore embedded basic types - only
user-defined
This is just an optimisation, I take it?

[gri, 2013-02-26 04:37:47]

https://codereview.appspot.com/7376055/diff/7001/src/pkg/go/types/operand.go
File src/pkg/go/types/operand.go (right):

https://codereview.appspot.com/7376055/diff/7001/src/pkg/go/types/operand.go#...
src/pkg/go/types/operand.go:303: // Ignore embedded basic types - only
user-defined
On 2013/02/26 04:34:27, adonovan wrote:
> This is just an optimisation, I take it?

Yes and no. The embeddedType requires that it's field typ is a *NamedType. I do
have to test as otherwise the type assertion may fail. One could test later, but
there's no reason for it.

I forgot that basic types can be named types too (and making them *NamedTypes
complicates other things - we have been there before).

[gri, 2013-02-26 04:42:43]

*** Submitted as https://code.google.com/p/go/source/detail?r=3be234555587 ***

go/types: embedded fields can be predeclared types

R=adonovan, r
CC=golang-dev
https://codereview.appspot.com/7376055