Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(651)

Issue 7376054: code review 7376054: libmach, cmd/5a, cmd/5c, cmd/5g, cmd/5l: enable DWARF t... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by minux1
Modified:
12 years, 3 months ago
Reviewers:
dave
CC:
golang-dev, rsc
Visibility:
Public.

Description

libmach, cmd/5a, cmd/5c, cmd/5g, cmd/5l: enable DWARF type info for Linux/ARM Fixes issue 3747. Update issue 4912 This CL adds gotype into .5 object file.

Patch Set 1 #

Patch Set 2 : diff -r 4b16fb118e08 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 4b16fb118e08 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 4b16fb118e08 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 4b16fb118e08 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 785fa44fa986 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -63 lines) Patch
M src/cmd/5a/lex.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/5c/swt.c View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/cmd/5g/gg.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/5g/gobj.c View 1 2 5 chunks +71 lines, -57 lines 0 comments Download
M src/cmd/5g/gsubr.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/5l/l.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/5l/obj.c View 1 2 3 4 7 chunks +30 lines, -4 lines 0 comments Download
M src/libmach/5obj.c View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 3 months ago (2013-02-25 21:13:19 UTC) #1
minux1
This changes the .5 object file format.
12 years, 3 months ago (2013-02-25 21:14:44 UTC) #2
rsc
LGTM, just revert reg.c https://codereview.appspot.com/7376054/diff/12001/src/cmd/5g/reg.c File src/cmd/5g/reg.c (right): https://codereview.appspot.com/7376054/diff/12001/src/cmd/5g/reg.c#newcode809 src/cmd/5g/reg.c:809: a->gotype = v->gotype; Delete. https://codereview.appspot.com/7376054/diff/12001/src/cmd/5g/reg.c#newcode1016 ...
12 years, 3 months ago (2013-02-25 21:24:40 UTC) #3
minux1
*** Submitted as https://code.google.com/p/go/source/detail?r=2b17033f6f17 *** libmach, cmd/5a, cmd/5c, cmd/5g, cmd/5l: enable DWARF type info for ...
12 years, 3 months ago (2013-02-25 22:15:44 UTC) #4
dave_cheney.net
12 years, 3 months ago (2013-02-25 22:16:15 UTC) #5
Wonderful, thank you.

On Tue, Feb 26, 2013 at 9:15 AM,  <minux.ma@gmail.com> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=2b17033f6f17 ***
>
>
> libmach, cmd/5a, cmd/5c, cmd/5g, cmd/5l: enable DWARF type info for
> Linux/ARM
> Fixes issue 3747.
>
> Update issue 4912
> This CL adds gotype into .5 object file.
>
> R=golang-dev, rsc
> CC=golang-dev
> https://codereview.appspot.com/7376054
>
>
>
> https://codereview.appspot.com/7376054/
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b