Issue 7375045: code review 7375045: bufio: add examples for Scanner

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7375045: code review 7375045: bufio: add examples for Scanner (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by r

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

bufio: add examples for Scanner Mention Scanner in docs for ReadLine etc.

Patch Set 2 : diff -r 15b3c390baf8 https://code.google.com/p/go #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -1 line)			Patch
	M	src/pkg/bufio/bufio.go	View		3 chunks	+3 lines, -1 line	0 comments	Download
	A	src/pkg/bufio/example_test.go	View	1	1 chunk	+74 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2013-02-20 20:14:54 UTC) #1

bradfitz

LGTM https://codereview.appspot.com/7375045/diff/1/src/pkg/bufio/example_test.go File src/pkg/bufio/example_test.go (right): https://codereview.appspot.com/7375045/diff/1/src/pkg/bufio/example_test.go#newcode21 src/pkg/bufio/example_test.go:21: if scanner.Err() != nil { if err := ...

12 years, 3 months ago (2013-02-21 22:51:39 UTC) #2

12 years, 3 months ago (2013-02-21 23:55:44 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=fbb1de9bc379 ***

bufio: add examples for Scanner
Mention Scanner in docs for ReadLine etc.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7375045

Expand All Messages | Collapse All Messages