code review 7373051: misc/emacs: Add tab completion for godoc command, compl...

misc/emacs: Add tab completion for godoc command, completing from known installed packages

[Dominik Honnef, 2013-02-26 19:14:30]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[adonovan, 2013-02-28 02:04:03]

LGTM

[Dominik Honnef, 2013-03-01 00:23:14]

Who is the best person to add to misc/emacs reviews to have them processed in a
speedy manner, anyway?

I have a couple of CLs for misc/emacs coming up, and I'd prefer if they didn't
take a week each :)

[bradfitz, 2013-03-01 00:28:53]

On Thu, Feb 28, 2013 at 4:23 PM, <dominik.honnef@gmail.com> wrote:

> Who is the best person to add to misc/emacs reviews to have them
> processed in a speedy manner, anyway?
>

The general policy is to just mail golang-dev when you don't specifically
care who reviews it.

It seems like adonovan and cshapiro use and know Emacs well, so they're
good candidates to nag.  You can mail "golang-dev, adonovan, cshapiro" if
you'd like.

I use emacs but don't do the elisp.  I think sameer is in the same camp.

I have a couple of CLs for misc/emacs coming up, and I'd prefer if they
> didn't take a week each :)


Smaller ones should go quicker at least, so hopefully it won't be too
painful.

Feel free to fire off multiple independent ones at once.  If they have
dependencies between them, say so in the CL description.

[Dominik Honnef, 2013-03-01 00:37:12]

On 2013/03/01 00:28:53, bradfitz wrote:
> On Thu, Feb 28, 2013 at 4:23 PM, <mailto:dominik.honnef@gmail.com> wrote:
> 
> > Who is the best person to add to misc/emacs reviews to have them
> > processed in a speedy manner, anyway?
> >
> 
> The general policy is to just mail golang-dev when you don't specifically
> care who reviews it.
> 
> It seems like adonovan and cshapiro use and know Emacs well, so they're
> good candidates to nag.  You can mail "golang-dev, adonovan, cshapiro" if
> you'd like.
> 
> I use emacs but don't do the elisp.  I think sameer is in the same camp.

Okay, thanks. I already included adonovan in this one, since he took part in the
last, big CL. I'll add cshapiro as well :)

> 
> I have a couple of CLs for misc/emacs coming up, and I'd prefer if they
> > didn't take a week each :)
> 
> 
> Smaller ones should go quicker at least, so hopefully it won't be too
> painful.
> 
> Feel free to fire off multiple independent ones at once.  If they have
> dependencies between them, say so in the CL description.

The problem is that they all affect the same file, and from what I've heard,
that can be quite the pain with the codereview plugin. And almost all changes
will kind of depend on another, or cause for hard to create patches. They're
all, in themselves, small CLs though. Hoping for the best.

[Dominik Honnef, 2013-03-03 18:34:33]

Hello golang-dev@googlegroups.com, adonovan@google.com, bradfitz@golang.org,
cw@f00f.org, patrick.allen.higgins@gmail.com, sameer@golang.org (cc:
cshapiro@golang.org, golang-dev@googlegroups.com),

Please take another look.

[adonovan, 2013-03-03 20:17:25]

LGTM

still lgtm :)

[pah, 2013-03-03 20:17:31]

I'm glad you wrote this, I wanted this as soon as I had the autocomplete for
package imports. The history deal isn't very important to me, I'm just curious
if there's a reason to not use a private history.

https://codereview.appspot.com/7373051/diff/14001/misc/emacs/go-mode.el
File misc/emacs/go-mode.el (right):

https://codereview.appspot.com/7373051/diff/14001/misc/emacs/go-mode.el#newco...
misc/emacs/go-mode.el:482: (go-packages) nil nil nil nil symbol)))
With nil hist, I see history items from e.g. describe-function in godoc history,
and godoc items in describe-function. Why not use a private history list?

[bradfitz, 2013-03-03 20:23:01]

Alan, you can submit.
 On Mar 3, 2013 12:17 PM, <adonovan@google.com> wrote:

> LGTM
>
> still lgtm :)
>
>
>
https://codereview.appspot.**com/7373051/<https://codereview.appspot.com/7373...
>

[Dominik Honnef, 2013-03-03 20:25:04]

https://codereview.appspot.com/7373051/diff/14001/misc/emacs/go-mode.el
File misc/emacs/go-mode.el (right):

https://codereview.appspot.com/7373051/diff/14001/misc/emacs/go-mode.el#newco...
misc/emacs/go-mode.el:482: (go-packages) nil nil nil nil symbol)))
On 2013/03/03 20:17:31, pah wrote:
> With nil hist, I see history items from e.g. describe-function in godoc
history,
> and godoc items in describe-function. Why not use a private history list?

Good idea. I simply overlooked that. The go-import-add command is also lacking
its own history list. I'll add it to godoc now, to go-import-add in a separate
CL. Thanks

[Dominik Honnef, 2013-03-03 20:57:20]

godoc has its own history now. This should be the last change to the CL :)

https://codereview.appspot.com/7373051/diff/14001/misc/emacs/go-mode.el
File misc/emacs/go-mode.el (right):

https://codereview.appspot.com/7373051/diff/14001/misc/emacs/go-mode.el#newco...
misc/emacs/go-mode.el:482: (go-packages) nil nil nil nil symbol)))
Done.

On 2013/03/03 20:25:04, Dominik Honnef wrote:
> On 2013/03/03 20:17:31, pah wrote:
> > With nil hist, I see history items from e.g. describe-function in godoc
> history,
> > and godoc items in describe-function. Why not use a private history list?
> 
> Good idea. I simply overlooked that. The go-import-add command is also lacking
> its own history list. I'll add it to godoc now, to go-import-add in a separate
> CL. Thanks

[pah, 2013-03-03 21:12:56]

LGTM

[ugorji, 2013-03-03 21:31:16]

On 2013/02/26 19:14:30, Dominik Honnef wrote:
> Hello mailto:golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go

*gocode* buffers fill up. Why is this? I currently have almost 300 empty buffers
named *gocode* to *gocode*<294> (all Fundamental mode buffers).

[Dominik Honnef, 2013-03-03 21:33:31]

On 2013/03/03 21:31:16, ugorji wrote:
> On 2013/02/26 19:14:30, Dominik Honnef wrote:
> > Hello mailto:golang-dev@googlegroups.com,
> > 
> > I'd like you to review this change to
> > https://code.google.com/p/go
> 
> *gocode* buffers fill up. Why is this? I currently have almost 300 empty
buffers
> named *gocode* to *gocode*<294> (all Fundamental mode buffers).

That's not the scope of this CL or go-mode.el. It's an issue in gocode, and
someone else reported it happened in combination with autocomplete.el but not
company.el.

[ugorji, 2013-03-03 21:36:08]

On 2013/03/03 21:33:31, Dominik Honnef wrote:
> On 2013/03/03 21:31:16, ugorji wrote:
> > On 2013/02/26 19:14:30, Dominik Honnef wrote:
> > > Hello mailto:golang-dev@googlegroups.com,
> > > 
> > > I'd like you to review this change to
> > > https://code.google.com/p/go
> > 
> > *gocode* buffers fill up. Why is this? I currently have almost 300 empty
> buffers
> > named *gocode* to *gocode*<294> (all Fundamental mode buffers).
> 
> That's not the scope of this CL or go-mode.el. It's an issue in gocode, and
> someone else reported it happened in combination with autocomplete.el but not
> company.el.

You're right. Brain-fart. Been up too long. Sorry.

[adonovan, 2013-03-04 20:32:00]

*** Submitted as https://code.google.com/p/go/source/detail?r=120c70d13b95 ***

misc/emacs: Add tab completion for godoc command, completing from known
installed packages

R=golang-dev, adonovan, bradfitz, cw, patrick.allen.higgins, sameer, ugorji
CC=golang-dev
https://codereview.appspot.com/7373051

Committer: Alan Donovan <adonovan@google.com>