Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

Issue 7373046: uniter: WantAllRelationsEvents() filter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by dimitern
Modified:
11 years, 1 month ago
Reviewers:
mp+149910
Visibility:
Public.

Description

uniter: WantAllRelationsEvents() filter This is the first CL in preparation for the implementation of upgrade-charm. Here, we'll prepare the Uniter to handle upgrades better, by restarting the relations watcher in the filter, when requested with WantAllRelationsEvents(). https://code.launchpad.net/~dimitern/juju-core/001-upgrade-charm-filter-restart-watchers/+merge/149910 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : uniter: restart filter relations watcher #

Total comments: 2

Patch Set 3 : uniter: WantAllRelationsEvents() filter #

Total comments: 4

Patch Set 4 : uniter: WantAllRelationsEvents() filter #

Patch Set 5 : uniter: WantAllRelationsEvents() filter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -16 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M worker/uniter/filter.go View 1 2 3 5 chunks +33 lines, -16 lines 0 comments Download
M worker/uniter/filter_test.go View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8
dimitern
Please take a look.
11 years, 1 month ago (2013-02-21 19:05:33 UTC) #1
dimitern
Please take a look.
11 years, 1 month ago (2013-02-21 19:07:29 UTC) #2
fwereade
On reflection, as discussed online, too much magic. I recommend a WantAllRelationsEvents method for clarity's ...
11 years, 1 month ago (2013-02-22 10:25:28 UTC) #3
dimitern
Please take a look. https://codereview.appspot.com/7373046/diff/3001/worker/uniter/filter.go File worker/uniter/filter.go (right): https://codereview.appspot.com/7373046/diff/3001/worker/uniter/filter.go#newcode226 worker/uniter/filter.go:226: return relationsw.Err() On 2013/02/22 10:25:28, ...
11 years, 1 month ago (2013-02-22 11:23:17 UTC) #4
fwereade
LGTM, one trivial https://codereview.appspot.com/7373046/diff/8001/worker/uniter/filter.go File worker/uniter/filter.go (right): https://codereview.appspot.com/7373046/diff/8001/worker/uniter/filter.go#newcode144 worker/uniter/filter.go:144: // pending relation changes. ...should send ...
11 years, 1 month ago (2013-02-22 11:25:33 UTC) #5
TheMue
LGTM https://codereview.appspot.com/7373046/diff/8001/worker/uniter/filter.go File worker/uniter/filter.go (right): https://codereview.appspot.com/7373046/diff/8001/worker/uniter/filter.go#newcode268 worker/uniter/filter.go:268: // restart the relations watcher Maybe too pedantic, ...
11 years, 1 month ago (2013-02-22 11:41:23 UTC) #6
dimitern
Please take a look. https://codereview.appspot.com/7373046/diff/8001/worker/uniter/filter.go File worker/uniter/filter.go (right): https://codereview.appspot.com/7373046/diff/8001/worker/uniter/filter.go#newcode144 worker/uniter/filter.go:144: // pending relation changes. On ...
11 years, 1 month ago (2013-02-22 14:11:57 UTC) #7
dimitern
11 years, 1 month ago (2013-02-22 14:13:24 UTC) #8
*** Submitted:

uniter: WantAllRelationsEvents() filter

This is the first CL in preparation for the
implementation of upgrade-charm. Here, we'll
prepare the Uniter to handle upgrades better,
by restarting the relations watcher in the
filter, when requested with WantAllRelationsEvents().

R=fwereade, TheMue
CC=
https://codereview.appspot.com/7373046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b