Issue 73730044: Fix build warnings

Issue 73730044: Fix build warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by Anthony Moore

Modified:
12 years, 7 months ago

Reviewers:
apatti, wonderfly

Base URL:
https://code.google.com/p/google-api-java-client/

Visibility:
Public.

More Reviews

Description

Fix build warnings

Patch Set 1 #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -2 lines)			Patch
M	google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/test/java/com/google/api/client/googleapis/MethodOverrideTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google-api-client/src/test/java/com/google/api/client/googleapis/auth/oauth2/GoogleIdTokenTest.java	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Anthony Moore

Daniel, meant to add you as a reviewer, but I must have gotten the command ...

12 years, 7 months ago (2014-03-10 22:32:50 UTC) #2

Daniel, meant to add you as a reviewer, but I must have gotten the command
wrong.


On Mon, Mar 10, 2014 at 3:23 PM, <anthm@google.com> wrote:

> Reviewers: apatti,
>
> Description:
> Fix build warnings
>
> Please review this at http://codereview.appspot.com/73730044/
>
> Affected files (+3, -2 lines):
>   M google-api-client/src/main/java/com/google/api/client/
> googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java
>   M google-api-client/src/test/java/com/google/api/client/
> googleapis/MethodOverrideTest.java
>   M google-api-client/src/test/java/com/google/api/client/
> googleapis/auth/oauth2/GoogleIdTokenTest.java
>
>
> Index: google-api-client/src/main/java/com/google/api/client/
> googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java
> ===================================================================
> --- a/google-api-client/src/main/java/com/google/api/client/
> googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java
> +++ b/google-api-client/src/main/java/com/google/api/client/
> googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java
> @@ -60,7 +60,7 @@
>          new MockLowLevelHttpResponse()
>          .setStatusCode(httpCode)
>          .setReasonPhrase(reasonPhrase);
> -    MockHttpTransport otherTransport = MockHttpTransport.builder()
> +    MockHttpTransport otherTransport = new MockHttpTransport.Builder()
>          .setLowLevelHttpResponse(otherServiceUnavaiableLowLevelResponse)
>          .build();
>      HttpRequest otherRequest = otherTransport
> Index: google-api-client/src/test/java/com/google/api/client/
> googleapis/MethodOverrideTest.java
> ===================================================================
> --- a/google-api-client/src/test/java/com/google/api/client/
> googleapis/MethodOverrideTest.java
> +++ b/google-api-client/src/test/java/com/google/api/client/
> googleapis/MethodOverrideTest.java
> @@ -54,7 +54,7 @@
>      subtestIntercept(ImmutableSet.<String>of(), new MockHttpTransport(),
> new MethodOverride());
>      subtestIntercept(OVERRIDDEN_METHODS, new MockHttpTransport(),
>          new MethodOverride.Builder().setOverrideAllMethods(true).
> build());
> -    subtestIntercept(OVERRIDDEN_METHODS, MockHttpTransport.builder()
> +    subtestIntercept(OVERRIDDEN_METHODS, new MockHttpTransport.Builder()
>          .setSupportedMethods(ImmutableSet.<String>of(HttpMethods.GET,
> HttpMethods.POST)).build(),
>          new MethodOverride());
>    }
> Index: google-api-client/src/test/java/com/google/api/client/
> googleapis/auth/oauth2/GoogleIdTokenTest.java
> ===================================================================
> --- a/google-api-client/src/test/java/com/google/api/client/
> googleapis/auth/oauth2/GoogleIdTokenTest.java
> +++ b/google-api-client/src/test/java/com/google/api/client/
> googleapis/auth/oauth2/GoogleIdTokenTest.java
> @@ -38,6 +38,7 @@
>      return payload;
>    }
>
> +  @SuppressWarnings("deprecation")
>    public void testDeprecatedMethods() {
>      Payload payload = newPayload(USER_ID, CLIENT_ID);
>      assertEquals(USER_ID, payload.getUserId());
>
>
>

apatti

Anthony, did you succeed in getting Daniel on the review? On Mon, Mar 10, 2014 ...

12 years, 7 months ago (2014-03-11 04:41:18 UTC) #3

Anthony, did you succeed in getting Daniel on the review?


On Mon, Mar 10, 2014 at 3:32 PM, Anthony Moore <anthm@google.com> wrote:

> Daniel, meant to add you as a reviewer, but I must have gotten the command
> wrong.
>
>
> On Mon, Mar 10, 2014 at 3:23 PM, <anthm@google.com> wrote:
>
>> Reviewers: apatti,
>>
>> Description:
>> Fix build warnings
>>
>> Please review this at http://codereview.appspot.com/73730044/
>>
>> Affected files (+3, -2 lines):
>>   M google-api-client/src/main/java/com/google/api/client/
>> googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java
>>   M google-api-client/src/test/java/com/google/api/client/
>> googleapis/MethodOverrideTest.java
>>   M google-api-client/src/test/java/com/google/api/client/
>> googleapis/auth/oauth2/GoogleIdTokenTest.java
>>
>>
>> Index: google-api-client/src/main/java/com/google/api/client/
>> googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java
>> ===================================================================
>> --- a/google-api-client/src/main/java/com/google/api/client/
>> googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java
>> +++ b/google-api-client/src/main/java/com/google/api/client/
>> googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java
>> @@ -60,7 +60,7 @@
>>          new MockLowLevelHttpResponse()
>>          .setStatusCode(httpCode)
>>          .setReasonPhrase(reasonPhrase);
>> -    MockHttpTransport otherTransport = MockHttpTransport.builder()
>> +    MockHttpTransport otherTransport = new MockHttpTransport.Builder()
>>          .setLowLevelHttpResponse(otherServiceUnavaiableLowLevelResponse)
>>          .build();
>>      HttpRequest otherRequest = otherTransport
>> Index: google-api-client/src/test/java/com/google/api/client/
>> googleapis/MethodOverrideTest.java
>> ===================================================================
>> --- a/google-api-client/src/test/java/com/google/api/client/
>> googleapis/MethodOverrideTest.java
>> +++ b/google-api-client/src/test/java/com/google/api/client/
>> googleapis/MethodOverrideTest.java
>> @@ -54,7 +54,7 @@
>>      subtestIntercept(ImmutableSet.<String>of(), new
>> MockHttpTransport(), new MethodOverride());
>>      subtestIntercept(OVERRIDDEN_METHODS, new MockHttpTransport(),
>>          new MethodOverride.Builder().setOverrideAllMethods(true).
>> build());
>> -    subtestIntercept(OVERRIDDEN_METHODS, MockHttpTransport.builder()
>> +    subtestIntercept(OVERRIDDEN_METHODS, new MockHttpTransport.Builder()
>>          .setSupportedMethods(ImmutableSet.<String>of(HttpMethods.GET,
>> HttpMethods.POST)).build(),
>>          new MethodOverride());
>>    }
>> Index: google-api-client/src/test/java/com/google/api/client/
>> googleapis/auth/oauth2/GoogleIdTokenTest.java
>> ===================================================================
>> --- a/google-api-client/src/test/java/com/google/api/client/
>> googleapis/auth/oauth2/GoogleIdTokenTest.java
>> +++ b/google-api-client/src/test/java/com/google/api/client/
>> googleapis/auth/oauth2/GoogleIdTokenTest.java
>> @@ -38,6 +38,7 @@
>>      return payload;
>>    }
>>
>> +  @SuppressWarnings("deprecation")
>>    public void testDeprecatedMethods() {
>>      Payload payload = newPayload(USER_ID, CLIENT_ID);
>>      assertEquals(USER_ID, payload.getUserId());
>>
>>
>>
>

wonderfly

Andy, yes, I am the primary reviewer now. On Mon, Mar 10, 2014 at 9:41 ...

12 years, 7 months ago (2014-03-11 04:46:04 UTC) #4

Andy, yes, I am the primary reviewer now.


On Mon, Mar 10, 2014 at 9:41 PM, Andrew Patti <apatti@google.com> wrote:

> Anthony, did you succeed in getting Daniel on the review?
>
>
> On Mon, Mar 10, 2014 at 3:32 PM, Anthony Moore <anthm@google.com> wrote:
>
>> Daniel, meant to add you as a reviewer, but I must have gotten the
>> command wrong.
>>
>>
>> On Mon, Mar 10, 2014 at 3:23 PM, <anthm@google.com> wrote:
>>
>>> Reviewers: apatti,
>>>
>>> Description:
>>> Fix build warnings
>>>
>>> Please review this at http://codereview.appspot.com/73730044/
>>>
>>> Affected files (+3, -2 lines):
>>>   M google-api-client/src/main/java/com/google/api/client/
>>> googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java
>>>   M google-api-client/src/test/java/com/google/api/client/
>>> googleapis/MethodOverrideTest.java
>>>   M google-api-client/src/test/java/com/google/api/client/
>>> googleapis/auth/oauth2/GoogleIdTokenTest.java
>>>
>>>
>>> Index: google-api-client/src/main/java/com/google/api/client/
>>> googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java
>>> ===================================================================
>>> --- a/google-api-client/src/main/java/com/google/api/client/
>>> googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java
>>> +++ b/google-api-client/src/main/java/com/google/api/client/
>>> googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java
>>> @@ -60,7 +60,7 @@
>>>          new MockLowLevelHttpResponse()
>>>          .setStatusCode(httpCode)
>>>          .setReasonPhrase(reasonPhrase);
>>> -    MockHttpTransport otherTransport = MockHttpTransport.builder()
>>> +    MockHttpTransport otherTransport = new MockHttpTransport.Builder()
>>>          .setLowLevelHttpResponse(otherServiceUnavaiableLowLevel
>>> Response)
>>>          .build();
>>>      HttpRequest otherRequest = otherTransport
>>> Index: google-api-client/src/test/java/com/google/api/client/
>>> googleapis/MethodOverrideTest.java
>>> ===================================================================
>>> --- a/google-api-client/src/test/java/com/google/api/client/
>>> googleapis/MethodOverrideTest.java
>>> +++ b/google-api-client/src/test/java/com/google/api/client/
>>> googleapis/MethodOverrideTest.java
>>> @@ -54,7 +54,7 @@
>>>      subtestIntercept(ImmutableSet.<String>of(), new
>>> MockHttpTransport(), new MethodOverride());
>>>      subtestIntercept(OVERRIDDEN_METHODS, new MockHttpTransport(),
>>>          new MethodOverride.Builder().setOverrideAllMethods(true).
>>> build());
>>> -    subtestIntercept(OVERRIDDEN_METHODS, MockHttpTransport.builder()
>>> +    subtestIntercept(OVERRIDDEN_METHODS, new
>>> MockHttpTransport.Builder()
>>>          .setSupportedMethods(ImmutableSet.<String>of(HttpMethods.GET,
>>> HttpMethods.POST)).build(),
>>>          new MethodOverride());
>>>    }
>>> Index: google-api-client/src/test/java/com/google/api/client/
>>> googleapis/auth/oauth2/GoogleIdTokenTest.java
>>> ===================================================================
>>> --- a/google-api-client/src/test/java/com/google/api/client/
>>> googleapis/auth/oauth2/GoogleIdTokenTest.java
>>> +++ b/google-api-client/src/test/java/com/google/api/client/
>>> googleapis/auth/oauth2/GoogleIdTokenTest.java
>>> @@ -38,6 +38,7 @@
>>>      return payload;
>>>    }
>>>
>>> +  @SuppressWarnings("deprecation")
>>>    public void testDeprecatedMethods() {
>>>      Payload payload = newPayload(USER_ID, CLIENT_ID);
>>>      assertEquals(USER_ID, payload.getUserId());
>>>
>>>
>>>
>>
>


-- 
Best,
Daniel

LGTM.

Expand All Messages | Collapse All Messages