Issue 7369059: code review 7369059: go/types: don't crash when assigning to undefined variables

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7369059: code review 7369059: go/types: don't crash when assigning to undefined variables (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by gri

Modified:
12 years, 3 months ago

Reviewers:

CC:
adonovan, golang-dev

Visibility:
Public.

Description

go/types: don't crash when assigning to undefined variables

Patch Set 1 #

Patch Set 2 : diff -r 8af82651506c https://code.google.com/p/go #

Patch Set 3 : diff -r 8af82651506c https://code.google.com/p/go #

Patch Set 4 : diff -r 8af82651506c https://code.google.com/p/go #

Patch Set 5 : diff -r 8af82651506c https://code.google.com/p/go #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/pkg/go/types/stmt.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/pkg/go/types/testdata/stmt0.src	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2013-02-27 22:20:59 UTC) #1

adonovan

On 2013/02/27 22:20:59, gri wrote: > Hello mailto:adonovan@google.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

12 years, 3 months ago (2013-02-27 22:22:59 UTC) #2

gri

12 years, 3 months ago (2013-02-27 22:25:15 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=4047f3c66025 ***

go/types: don't crash when assigning to undefined variables

R=adonovan
CC=golang-dev
https://codereview.appspot.com/7369059

Expand All Messages | Collapse All Messages