Wire Landscape helper into App and DB

Wire Landscape helper into App and DB

This connects the landscape object into App
and extends the delta processing to update
db.environment annotations.

https://code.launchpad.net/~bcsaller/juju-gui/landscape-links/+merge/150452

(do not edit description out of merge proposal)

[bcsaller, 2013-02-26 18:45:23]

Please take a look.

[matthew.scott, 2013-02-26 18:58:38]

LGTM with change.

This drives the current bottom-toolbar branch well with the diff I link in the
comment and the delta-annotations juju branch.  Thanks for the branches!

https://codereview.appspot.com/7369054/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/7369054/diff/1/app/app.js#newcode259
app/app.js:259: this.after('update', this.landscape.update, this.landscape);
The app doesn't publish an update event, so this would be
this.db.after('update'...);  However, given that this.db.on('update'...) fires
the update in the active view, and this.db.after() doesn't, any changes would be
propagated to the view on the -next- delta.

Suggestion: http://pastebin.ubuntu.com/5568288/ - this updates the landscape
annotations before the active view is updated.  In that same method, we're
updating available endpoints already, so work in that method is not
unprecedented.

[bcsaller, 2013-02-26 19:04:34]

On 2013/02/26 18:58:38, matthew.scott wrote:
> LGTM with change.
> 
> This drives the current bottom-toolbar branch well with the diff I link in the
> comment and the delta-annotations juju branch.  Thanks for the branches!
> 
> https://codereview.appspot.com/7369054/diff/1/app/app.js
> File app/app.js (right):
> 
> https://codereview.appspot.com/7369054/diff/1/app/app.js#newcode259
> app/app.js:259: this.after('update', this.landscape.update, this.landscape);
> The app doesn't publish an update event, so this would be
> this.db.after('update'...);  However, given that this.db.on('update'...) fires
> the update in the active view, and this.db.after() doesn't, any changes would
be
> propagated to the view on the -next- delta.
> 
> Suggestion: http://pastebin.ubuntu.com/5568288/ - this updates the landscape
> annotations before the active view is updated.  In that same method, we're
> updating available endpoints already, so work in that method is not
> unprecedented.

Thanks for this, I misread it the first time, but you're right this is better
(and actually works), applied.

[jeff.pihach, 2013-02-26 19:23:29]

LGTM but plz review note to see if that applies to this branch.

https://codereview.appspot.com/7369054/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/7369054/diff/1/app/app.js#newcode259
app/app.js:259: this.after('update', this.landscape.update, this.landscape);
Because this update event is being fired from another class you should listen
for the namespaced version of that event to avoid event name clashes ex)
this.on('database:update', ...);

That is possibly outside the scope of this branch because I'm sure that other
parts of the application rely on that event but I wanted to point it out.

[bcsaller, 2013-02-26 19:24:25]

On 2013/02/26 19:23:29, jeff.pihach wrote:
> LGTM but plz review note to see if that applies to this branch.
> 
> https://codereview.appspot.com/7369054/diff/1/app/app.js
> File app/app.js (right):
> 
> https://codereview.appspot.com/7369054/diff/1/app/app.js#newcode259
> app/app.js:259: this.after('update', this.landscape.update, this.landscape);
> Because this update event is being fired from another class you should listen
> for the namespaced version of that event to avoid event name clashes ex)
> this.on('database:update', ...);
> 
> That is possibly outside the scope of this branch because I'm sure that other
> parts of the application rely on that event but I wanted to point it out.

Thanks for the note and the the review.

[bcsaller, 2013-02-26 19:30:44]

*** Submitted:

Wire Landscape helper into App and DB

This connects the landscape object into App
and extends the delta processing to update
db.environment annotations.

R=matthew.scott, jeff.pihach
CC=
https://codereview.appspot.com/7369054