Issue 7369044: code review 7369044: cmd/go: don't call ImportDir unnecessarily

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7369044: code review 7369044: cmd/go: don't call ImportDir unnecessarily (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by ality

Modified:
11 years, 7 months ago

Reviewers:

CC:
rsc, r, golang-dev

Visibility:
Public.

Description

cmd/go: don't call ImportDir unnecessarily This significantly speeds up the go tool on slow file systems (or those with cold caches). The following numbers were obtained using an encrypted ext4 file system running on Linux 3.7.9. # Before $ sudo sysctl -w 'vm.drop_caches=3' $ time go list code.google.com/p/go.net/... | wc -l 9 real 0m16.921s user 0m0.637s sys 0m0.317s # After $ sudo sysctl -w 'vm.drop_caches=3' $ time go list code.google.com/p/go.net/... | wc -l 9 real 0m8.175s user 0m0.220s sys 0m0.177s

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -13 lines)			Patch
	M	src/cmd/go/main.go	View	1	2 chunks	+14 lines, -13 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-02-20 11:41:10 UTC) #1

ality

11 years, 7 months ago (2013-02-22 04:09:37 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=1852ee47001a ***

cmd/go: don't call ImportDir unnecessarily

This significantly speeds up the go tool on
slow file systems (or those with cold caches).

The following numbers were obtained using
an encrypted ext4 file system running on
Linux 3.7.9.

# Before
$ sudo sysctl -w 'vm.drop_caches=3'
$ time go list code.google.com/p/go.net/... | wc -l
9

real	0m16.921s
user	0m0.637s
sys	0m0.317s

# After
$ sudo sysctl -w 'vm.drop_caches=3'
$ time go list code.google.com/p/go.net/... | wc -l
9

real	0m8.175s
user	0m0.220s
sys	0m0.177s

R=rsc, r
CC=golang-dev
https://codereview.appspot.com/7369044

Expand All Messages | Collapse All Messages