Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1815)

Issue 7365056: code review 7365056: cmd/gc: accept cases with same value but different type... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by remyoudompheng
Modified:
11 years, 1 month ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

cmd/gc: accept cases with same value but different types in switch. Fixes issue 4781.

Patch Set 1 #

Patch Set 2 : diff -r 3b285c00863b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3b285c00863b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e73800eb2b00 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M src/cmd/gc/swt.c View 1 2 chunks +8 lines, -4 lines 0 comments Download
M test/switch.go View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 3
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 1 month ago (2013-02-24 22:44:53 UTC) #1
rsc
LGTM
11 years, 1 month ago (2013-02-25 22:07:22 UTC) #2
remyoudompheng
11 years, 1 month ago (2013-02-25 23:45:51 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=06510582fad7 ***

cmd/gc: accept cases with same value but different types in switch.

Fixes issue 4781.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7365056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b