code review 7365055: syscall: add network interface announce support on BSD ...

syscall: add network interface announce support on BSD variants

This CL allows to receive network interface arrival and depature
notifications through routing sockets on BSD variants. So far
Darwin doesn't support this feature.

Also does small simplification.

Update issue 4866.

[mikio, 2013-02-23 10:15:02]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[lucio, 2013-02-23 10:46:50]

Dariwn? In the CL description, worth fixing now.

Lucio.

On 2/23/13, mikioh.mikioh@gmail.com <mikioh.mikioh@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> syscall: add network interface announce support on BSD variants
>
> This CL allows to receive network interface arrival and depature
> notifications through routing sockets on BSD variants. So far
> Dariwn doesn't support this feature.
>
> Also does small simplification.
>
> Please review this at https://codereview.appspot.com/7365055/
>
> Affected files:
>    M src/pkg/syscall/route_bsd.go
>    M src/pkg/syscall/route_darwin.go
>    M src/pkg/syscall/route_freebsd.go
>    M src/pkg/syscall/route_netbsd.go
>    M src/pkg/syscall/route_openbsd.go
>
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

[mikio, 2013-02-23 10:53:28]

On Sat, Feb 23, 2013 at 7:46 PM, Lucio De Re <lucio.dere@gmail.com> wrote:

> Dariwn? In the CL description, worth fixing now.

thx.

[dave_cheney.net, 2013-02-24 01:43:36]

LGTM. Thank you.

https://codereview.appspot.com/7365055/diff/7001/src/pkg/syscall/route_freebs...
File src/pkg/syscall/route_freebsd.go (right):

https://codereview.appspot.com/7365055/diff/7001/src/pkg/syscall/route_freebs...
src/pkg/syscall/route_freebsd.go:34: type InterfaceAnnounceMessage struct {
Can this be moved to route_bsd.go ?

[mikio, 2013-02-24 01:57:34]

Thanks.

On Sun, Feb 24, 2013 at 10:43 AM,  <dave@cheney.net> wrote:

> src/pkg/syscall/route_freebsd.go:34: type InterfaceAnnounceMessage
> struct {
> Can this be moved to route_bsd.go ?

nope, darwin doesn't have it.

[dave_cheney.net, 2013-02-24 02:07:54]

Grrr, I knew there was a reason

On Sun, Feb 24, 2013 at 12:57 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
> Thanks.
>
> On Sun, Feb 24, 2013 at 10:43 AM,  <dave@cheney.net> wrote:
>
>> src/pkg/syscall/route_freebsd.go:34: type InterfaceAnnounceMessage
>> struct {
>> Can this be moved to route_bsd.go ?
>
> nope, darwin doesn't have it.

[mikio, 2013-02-24 03:36:53]

*** Submitted as https://code.google.com/p/go/source/detail?r=5b495d0aefcf ***

syscall: add network interface announce support on BSD variants

This CL allows to receive network interface arrival and depature
notifications through routing sockets on BSD variants. So far
Darwin doesn't support this feature.

Also does small simplification.

Update issue 4866.

R=golang-dev, lucio.dere, dave
CC=golang-dev
https://codereview.appspot.com/7365055