Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1360)

Issue 7365044: Properly encode maas tags in urls.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by hazmat
Modified:
6 years, 6 months ago
Reviewers:
mp+149586, gz
Visibility:
Public.

Description

Properly encode maas tags in urls. Hopefully the last in the sordid history of maas tag support. Revno 616 reverted attempts to string serialize tags for urls, but which had broken constraint comparisions. Those string serialization had been attempt in revno 597 and 598 to encode maas tags properly for maas client usage. This branch properly captures the raw tags string for use by the client, while preserving the constraint comparisons restored in revno 616. https://code.launchpad.net/~hazmat/juju/maas-with-tags/+merge/149586 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Properly encode maas tags in urls. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -11 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M juju/providers/maas/maas.py View 3 chunks +16 lines, -6 lines 0 comments Download
M juju/providers/maas/tests/test_launch.py View 3 chunks +23 lines, -4 lines 0 comments Download
M juju/providers/maas/tests/test_maas.py View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 4
hazmat
Please take a look.
6 years, 6 months ago (2013-02-20 14:46:53 UTC) #1
gz
Fix LGTM. The one thing I'm not clear on is if there's still any route ...
6 years, 6 months ago (2013-02-20 17:50:09 UTC) #2
hazmat
ux Thanks for the review. On Wed, Feb 20, 2013 at 12:50 PM, <martin.packman@canonical.com> wrote: ...
6 years, 6 months ago (2013-02-22 13:10:21 UTC) #3
hazmat
6 years, 6 months ago (2013-02-22 13:12:22 UTC) #4
*** Submitted:

Properly encode maas tags in urls.

Hopefully the last in the sordid history of maas tag support. Revno 616 reverted

attempts to string serialize tags for urls, but which had broken constraint 
comparisions. Those string serialization had been attempt in revno 597 and 598 
to encode maas tags properly for maas client usage. This branch properly 
captures the raw tags string for use by the client, while preserving the 
constraint comparisons restored in revno 616.

R=gz
CC=
https://codereview.appspot.com/7365044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b