Issue 7363045: code review 7363045: mime: use Scanner to read mime files during init

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7363045: code review 7363045: mime: use Scanner to read mime files during init (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by r

Modified:
12 years ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

mime: use Scanner to read mime files during init Also close the file when we're done.

Patch Set 2 : diff -r ac7cf6ff2de8 https://code.google.com/p/go #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
	M	src/pkg/mime/type_unix.go	View	1	2 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years ago (2013-02-20 21:03:36 UTC) #1

bradfitz

LGTM https://codereview.appspot.com/7363045/diff/1/src/pkg/mime/type_unix.go File src/pkg/mime/type_unix.go (right): https://codereview.appspot.com/7363045/diff/1/src/pkg/mime/type_unix.go#newcode26 src/pkg/mime/type_unix.go:26: defer f.Close() nice https://codereview.appspot.com/7363045/diff/1/src/pkg/mime/type_unix.go#newcode42 src/pkg/mime/type_unix.go:42: // TODO: check ...

12 years ago (2013-02-20 22:18:28 UTC) #2

12 years ago (2013-02-20 22:34:05 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=5bb68f12d0a9 ***

mime: use Scanner to read mime files during init
Also close the file when we're done.

R=bradfitz
CC=golang-dev
https://codereview.appspot.com/7363045

Expand All Messages | Collapse All Messages