Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(907)

Issue 7363043: code review 7363043: database/sql: refcounting and lifetime fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by bradfitz
Modified:
7 years, 11 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

database/sql: refcounting and lifetime fixes Simplifies the contract for Driver.Stmt.Close in the process of fixing issue 3865. Fixes issue 3865 Update issue 4459 (maybe fixes it; uninvestigated)

Patch Set 1 #

Patch Set 2 : diff -r d46d4fb24d4f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d46d4fb24d4f https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 1d5a80b07916 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -55 lines) Patch
M src/pkg/database/sql/driver/driver.go View 1 1 chunk +2 lines, -17 lines 0 comments Download
M src/pkg/database/sql/sql.go View 1 2 3 15 chunks +167 lines, -29 lines 0 comments Download
M src/pkg/database/sql/sql_test.go View 1 4 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 11 months ago (2013-02-20 01:18:34 UTC) #1
rsc
LGTM https://codereview.appspot.com/7363043/diff/5001/src/pkg/database/sql/sql.go File src/pkg/database/sql/sql.go (right): https://codereview.appspot.com/7363043/diff/5001/src/pkg/database/sql/sql.go#newcode312 src/pkg/database/sql/sql.go:312: //XXX fmt.Printf("outConn(%v) from free\n", conn) ? https://codereview.appspot.com/7363043/diff/5001/src/pkg/database/sql/sql.go#newcode320 src/pkg/database/sql/sql.go:320: ...
7 years, 11 months ago (2013-02-20 22:47:08 UTC) #2
bradfitz
7 years, 11 months ago (2013-02-20 23:35:32 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=ddb9e6365e57 ***

database/sql: refcounting and lifetime fixes

Simplifies the contract for Driver.Stmt.Close in
the process of fixing issue 3865.

Fixes issue 3865
Update issue 4459 (maybe fixes it; uninvestigated)

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7363043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b