Issue 7359044: state: don't panic on dial failure

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7359044: state: don't panic on dial failure

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by rog

Modified:
11 years, 2 months ago

Reviewers:
dimitern, mp+149321, dave, jameinel

Visibility:
Public.

Description

state: don't panic on dial failure https://code.launchpad.net/~rogpeppe/juju-core/226-fix-dial-panic/+merge/149321 (do not edit description out of merge proposal)

Patch Set 2 : state: don't panic on dial failure #

Total comments: 3

Patch Set 3 : state: don't panic on dial failure #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -1 line)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/export_test.go	View	1 2	2 chunks	+12 lines, -0 lines	0 comments	Download
M	state/open.go	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	state/state_test.go	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

On 2013/02/19 16:37:02, dimitern wrote: > LGTM, good catch! LGTM, thank you

11 years, 2 months ago (2013-02-19 22:35:26 UTC) #3

jameinel

LGTM https://codereview.appspot.com/7359044/diff/2001/state/export_test.go File state/export_test.go (right): https://codereview.appspot.com/7359044/diff/2001/state/export_test.go#newcode18 state/export_test.go:18: var oldDialTimeout = dialTimeout I would call this ...

11 years, 2 months ago (2013-02-20 05:46:39 UTC) #4

rog

11 years, 2 months ago (2013-02-20 09:38:55 UTC) #5

*** Submitted:

state: don't panic on dial failure

R=dimitern, dfc, jameinel
CC=
https://codereview.appspot.com/7359044

https://codereview.appspot.com/7359044/diff/2001/state/export_test.go
File state/export_test.go (right):

https://codereview.appspot.com/7359044/diff/2001/state/export_test.go#newcode18
state/export_test.go:18: var oldDialTimeout = dialTimeout
On 2013/02/20 05:46:40, jameinel wrote:
> I would call this "defaultDialTimeout".
> 
> Old would indicate the timeout-used-before-I-just-set-it, but nothing but this
> line sets "oldDialTimeout".
> Calling it default makes it clearer that passing 0 just reverts it to the
> default.

Done.

Expand All Messages | Collapse All Messages