state/api: optionally log messages

state/api: optionally log messages

It's useful to be able to see a record of the
messages on the wire.

https://code.launchpad.net/~rogpeppe/juju-core/225-api-log-messages/+merge/149252

(do not edit description out of merge proposal)

[TheMue, 2013-02-19 11:57:01]

LGTM, only like "read" and "write" more than "<-" and "->".

[dimitern, 2013-02-19 11:57:49]

LGTM, with a couple of comments.

https://codereview.appspot.com/7358045/diff/1/state/api/server.go
File state/api/server.go (right):

https://codereview.appspot.com/7358045/diff/1/state/api/server.go#newcode122
state/api/server.go:122: log.Printf("api: <- %s", m)
log.Debugf instead? this seems it'll happen often enough to make it a debug log.

https://codereview.appspot.com/7358045/diff/1/state/api/server.go#newcode198
state/api/server.go:198: log.Printf("api: -> %s", data)
as above

[rog, 2013-02-19 12:13:34]

*** Submitted:

state/api: optionally log messages

It's useful to be able to see a record of the
messages on the wire.

R=TheMue, dimitern
CC=
https://codereview.appspot.com/7358045

https://codereview.appspot.com/7358045/diff/1/state/api/server.go
File state/api/server.go (right):

https://codereview.appspot.com/7358045/diff/1/state/api/server.go#newcode122
state/api/server.go:122: log.Printf("api: <- %s", m)
On 2013/02/19 11:57:49, dimitern wrote:
> log.Debugf instead? this seems it'll happen often enough to make it a debug
log.

Done.

https://codereview.appspot.com/7358045/diff/1/state/api/server.go#newcode198
state/api/server.go:198: log.Printf("api: -> %s", data)
On 2013/02/19 11:57:49, dimitern wrote:
> as above

Done.

[rog, 2013-02-19 12:14:30]

On 19 February 2013 11:57,  <themue@gmail.com> wrote:
> LGTM, only like "read" and "write" more than "<-" and "->".

as discussed online, the arrows stand out nicely in the log.