state: unexport NotFoundError

state: unexport NotFoundError

We export NotFoundf instead, making NotFoundError
redundant. This makes it possible for external
clients to create errors that satisfy IsNotFound.

https://code.launchpad.net/~rogpeppe/juju-core/222-unexport-notfounderror/+merge/149104

Requires: https://code.launchpad.net/~rogpeppe/juju-core/221-instanceid-bool/+merge/149097

(do not edit description out of merge proposal)

[rog, 2013-02-18 17:20:23]

Please take a look.

[dave_cheney.net, 2013-02-18 22:16:00]

On 2013/02/18 17:20:23, rog wrote:
> Please take a look.

LGTM. Thank you.

[jameinel, 2013-02-19 10:24:54]

Obviously 99% of this is just the mechanical replacement of n=>N and N=>n which
LGTM.

I'm just trying to understand the actual change. This is so you can more easily
call NotFoundf("err string") rather than instantiating your own NotFoundError
struct directly? If I understand that correctly, LGTM.

[dimitern, 2013-02-19 10:39:23]

LGTM, nice!

[rog, 2013-02-19 11:44:03]

*** Submitted:

state: unexport NotFoundError

We export NotFoundf instead, making NotFoundError
redundant. This makes it possible for external
clients to create errors that satisfy IsNotFound.

R=dfc, jameinel, dimitern
CC=
https://codereview.appspot.com/7354044