Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(364)

Issue 7343050: code review 7343050: undo CL 7310096 / 59da6744d66d (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by rsc
Modified:
12 years, 4 months ago
Reviewers:
dvyukov
CC:
golang-dev
Visibility:
Public.

Description

undo CL 7310096 / 59da6744d66d broke windows build ««« original CL description runtime: ensure forward progress of runtime.Gosched() for locked goroutines The removed code leads to the situation when M executes the same locked G again and again. Fixes issue 4820. R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/7310096 »»»

Patch Set 1 #

Patch Set 2 : diff -r 16ded815310d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -30 lines) Patch
M src/pkg/runtime/proc.c View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/pkg/runtime/proc_test.go View 1 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello dvyukov (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 4 months ago (2013-02-15 22:54:44 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=864c37196df8 *** undo CL 7310096 / 59da6744d66d broke windows build ««« original ...
12 years, 4 months ago (2013-02-15 22:54:51 UTC) #2
dvyukov
12 years, 4 months ago (2013-02-17 07:08:13 UTC) #3
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b