Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(178)

Issue 7341044: Unit process multiple relations in defined order.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by hazmat
Modified:
6 years, 2 months ago
Reviewers:
mp+148528, bcsaller
Visibility:
Public.

Description

Unit process multiple relations in defined order. Previously when unit agents were being notified of multiple relations, typicaly at startup, they would process them in essentially random order. This would complicate things for applications that would have peer relations as well, for ha or replication, as they couldn't tell if they were being run standalone or in a cluster/quorum. Instead when a unit has multiple relations, we process peer relations first followed by client/server relations. https://code.launchpad.net/~hazmat/juju/peers-from-hurd/+merge/148528 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Unit process multiple relations in defined order. #

Patch Set 3 : Unit process multiple relations in defined order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -12 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M juju/control/remove_relation.py View 1 1 chunk +1 line, -1 line 0 comments Download
M juju/unit/lifecycle.py View 1 3 chunks +39 lines, -5 lines 0 comments Download
M juju/unit/tests/test_lifecycle.py View 1 4 chunks +20 lines, -6 lines 0 comments Download

Messages

Total messages: 6
hazmat
Please take a look.
6 years, 2 months ago (2013-02-14 18:37:40 UTC) #1
bcsaller
LGTM so long as contract is documented as we talked about on the call. Thanks.
6 years, 2 months ago (2013-02-14 19:40:55 UTC) #2
hazmat
Please take a look.
6 years, 2 months ago (2013-02-14 23:01:19 UTC) #3
hazmat
On 2013/02/14 23:01:19, hazmat wrote: > Please take a look. this time more explicit about ...
6 years, 2 months ago (2013-02-14 23:03:17 UTC) #4
bcsaller
That is better, thanks for following up on that. +1
6 years, 2 months ago (2013-02-14 23:05:34 UTC) #5
hazmat
6 years, 2 months ago (2013-02-14 23:07:51 UTC) #6
*** Submitted:

Unit process multiple relations in defined order.

Previously when unit agents were being notified of multiple relations, typicaly 
at startup, they would process them in essentially random order. This would 
complicate things for applications that would have peer relations as well, for 
ha or replication, as they couldn't tell if they were being run standalone or
in a cluster/quorum. Instead when a unit has multiple relations, we process
peer relations first followed by client/server relations.

R=bcsaller
CC=
https://codereview.appspot.com/7341044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b