Issue 7338045: code review 7338045: net/rpc: avoid racy use of closing flag.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7338045: code review 7338045: net/rpc: avoid racy use of closing flag. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by rog

Modified:
10 years, 3 months ago

Reviewers:

CC:
r, iant, golang-dev

Visibility:
Public.

Description

net/rpc: avoid racy use of closing flag. It's accessed without mutex protection in a different goroutine from the one that sets it. Also make sure that Client.Call after Client.Close will reliably return ErrShutdown, and that clients see ErrShutdown rather than io.EOF when appropriate. Suggestions welcome for a way to reliably test the mutex issue.

Patch Set 1 #

Patch Set 2 : diff -r 6b42c681480b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6b42c681480b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6b42c681480b https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 6b42c681480b https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 6b42c681480b https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 6b42c681480b https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 6b42c681480b https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r cac5b17d8699 https://go.googlecode.com/hg/ #

Patch Set 10 : diff -r cac5b17d8699 https://go.googlecode.com/hg/ #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -4 lines)			Patch
	M	src/pkg/net/rpc/client.go	View	1 2 3	3 chunks	+8 lines, -4 lines	0 comments	Download
	M	src/pkg/net/rpc/server_test.go	View	1 2 3 4 5 6	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 3 months ago (2013-02-15 14:01:25 UTC) #1

rog

10 years, 3 months ago (2013-02-25 16:22:37 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=4bbd9bfda787 ***

net/rpc: avoid racy use of closing flag.

It's accessed without mutex protection
in a different goroutine from the one that
sets it.

Also make sure that Client.Call after Client.Close
will reliably return ErrShutdown, and that clients
see ErrShutdown rather than io.EOF when appropriate.

Suggestions welcome for a way to reliably test
the mutex issue.

R=r, iant
CC=golang-dev
https://codereview.appspot.com/7338045

Expand All Messages | Collapse All Messages