Issue 7337048: code review 7337048: codereview: give up on http fetch after 30 seconds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7337048: code review 7337048: codereview: give up on http fetch after 30 seconds (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by rsc

Modified:
12 years, 4 months ago

Reviewers:

CC:
golang-dev, bradfitz, minux1

Visibility:
Public.

Description

codereview: give up on http fetch after 30 seconds If Python blocks in the SSL handshake it seems to be completely uninterruptible, and I've been seeing it block for at least hours recently. I don't know if the problem is on the client side or the server side or somewhere in the network, but setting the timeout at least means you're guaranteed a new shell prompt (after printing some errors).

Patch Set 1 #

Patch Set 2 : diff -r cb5d4e9555d2 https://code.google.com/p/go/ #

Patch Set 3 : diff -r cb5d4e9555d2 https://code.google.com/p/go/ #

Patch Set 4 : diff -r cb5d4e9555d2 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 4ccc0b275911 https://code.google.com/p/go/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	lib/codereview/codereview.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 4 months ago (2013-02-19 15:12:26 UTC) #1

rsc

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 4 months ago (2013-02-19 15:13:33 UTC) #2

bradfitz

LGTM On Tue, Feb 19, 2013 at 7:13 AM, <rsc@golang.org> wrote: > Hello golang-dev@googlegroups.com (cc: ...

12 years, 4 months ago (2013-02-19 15:15:01 UTC) #3

minux1

LGTM. Thank you, this blocking problem happens frequently for me due to network problems.

12 years, 4 months ago (2013-02-19 15:16:25 UTC) #4

rsc

12 years, 4 months ago (2013-02-19 15:18:20 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=279b715acac8 ***

codereview: give up on http fetch after 30 seconds

If Python blocks in the SSL handshake it seems to be
completely uninterruptible, and I've been seeing it
block for at least hours recently. I don't know if the
problem is on the client side or the server side or
somewhere in the network, but setting the timeout
at least means you're guaranteed a new shell prompt
(after printing some errors).

R=golang-dev, bradfitz, minux.ma
CC=golang-dev
https://codereview.appspot.com/7337048

Expand All Messages | Collapse All Messages