state: add service constraints

state: add service constraints



https://code.launchpad.net/~fwereade/juju-core/state-service-constraints/+merge/148944

Requires: https://code.launchpad.net/~fwereade/juju-core/state-environ-constraints/+merge/148942

(do not edit description out of merge proposal)

[fwereade, 2013-02-17 15:44:43]

Please take a look.

[jameinel, 2013-02-20 05:35:35]

LGTM

https://codereview.appspot.com/7331053/diff/1/state/service.go
File state/service.go (right):

https://codereview.appspot.com/7331053/diff/1/state/service.go#newcode478
state/service.go:478: return readConstraints(s.st, s.globalKey())
I don't quite understand where read and writeConstraints are coming from, but as
long as they are around, these seem fine.

[TheMue, 2013-02-20 13:00:06]

LGTM

https://codereview.appspot.com/7331053/diff/1/state/service.go
File state/service.go (right):

https://codereview.appspot.com/7331053/diff/1/state/service.go#newcode478
state/service.go:478: return readConstraints(s.st, s.globalKey())
On 2013/02/20 05:35:35, jameinel wrote:
> I don't quite understand where read and writeConstraints are coming from, but
as
> long as they are around, these seem fine.

They are helpers to be also used on the environment constraints.

[rog, 2013-02-20 13:13:43]

On 2013/02/20 13:00:06, TheMue wrote:
> LGTM
> 
> https://codereview.appspot.com/7331053/diff/1/state/service.go
> File state/service.go (right):
> 
> https://codereview.appspot.com/7331053/diff/1/state/service.go#newcode478
> state/service.go:478: return readConstraints(s.st, s.globalKey())
> On 2013/02/20 05:35:35, jameinel wrote:
> > I don't quite understand where read and writeConstraints are coming from,
but
> as
> > long as they are around, these seem fine.
> 
> They are helpers to be also used on the environment constraints.

LGTM

[fwereade, 2013-02-20 13:29:03]

*** Submitted:

state: add service constraints

R=jameinel, TheMue, rog
CC=
https://codereview.appspot.com/7331053

https://codereview.appspot.com/7331053/diff/1/state/service.go
File state/service.go (right):

https://codereview.appspot.com/7331053/diff/1/state/service.go#newcode478
state/service.go:478: return readConstraints(s.st, s.globalKey())
On 2013/02/20 05:35:35, jameinel wrote:
> I don't quite understand where read and writeConstraints are coming from, but
as
> long as they are around, these seem fine.

They're in state/constraints.go; added in the prereq.