Set lxc autostart after creation.

Set lxc autostart after creation.

Currently for a recent LXC version, the autostart is controlled
by a setting in the lxc config.  We were setting this in the
config file that we use for creation.  However this is not clone
friendly, as we do not specify a config file for clone.

However it is perfectly valid to modify the config for the container
once it has been created.  This then becomes common for both
normally created containers and those that have been cloned.

A key here is that our template container that we want to use
as a base to clone off we do not want auto-starting, however
the containers that we clone off that may well want to auto-start
(in fact all will until we add the autostart policy for local).

https://code.launchpad.net/~thumper/juju-core/autostart-containers-after-creation/+merge/210099

Requires: https://code.launchpad.net/~thumper/juju-core/fast-lxc/+merge/209801

(do not edit description out of merge proposal)

[thumper, 2014-03-09 21:29:35]

Please take a look.

[waigani, 2014-03-10 23:58:26]

On 2014/03/09 21:29:35, thumper wrote:
> Please take a look.

LGTM

[axw, 2014-03-11 02:24:13]

https://codereview.appspot.com/73300043/diff/1/container/lxc/lxc_test.go
File container/lxc/lxc_test.go (right):

https://codereview.appspot.com/73300043/diff/1/container/lxc/lxc_test.go#newc...
container/lxc/lxc_test.go:179: name := string(instance.Id())
It's not clear why this has changed. Has something caused the contents of the
file to be different (apart from the lxc.start.auto)? I would think it's
preferable to match exactly if it's not too onerous.

https://codereview.appspot.com/73300043/diff/1/container/lxc/mock/mock-lxc.go
File container/lxc/mock/mock-lxc.go (right):

https://codereview.appspot.com/73300043/diff/1/container/lxc/mock/mock-lxc.go...
container/lxc/mock/mock-lxc.go:87: data, err := ioutil.ReadFile(configFile)
There's utils.CopyFile, if you didn't know.

https://codereview.appspot.com/73300043/diff/1/container/lxc/mock/mock-lxc.go...
container/lxc/mock/mock-lxc.go:92: return ioutil.WriteFile(configFilename, data,
0755)
0644?

[thumper, 2014-03-11 03:46:16]

Please take a look.

https://codereview.appspot.com/73300043/diff/1/container/lxc/lxc_test.go
File container/lxc/lxc_test.go (right):

https://codereview.appspot.com/73300043/diff/1/container/lxc/lxc_test.go#newc...
container/lxc/lxc_test.go:179: name := string(instance.Id())
On 2014/03/11 02:24:13, axw wrote:
> It's not clear why this has changed. Has something caused the contents of the
> file to be different (apart from the lxc.start.auto)? I would think it's
> preferable to match exactly if it's not too onerous.

Doing an exact match now.

In order to make the match easily, I have also added in the part where the
mounting of the log dir is done after create.

https://codereview.appspot.com/73300043/diff/1/container/lxc/mock/mock-lxc.go
File container/lxc/mock/mock-lxc.go (right):

https://codereview.appspot.com/73300043/diff/1/container/lxc/mock/mock-lxc.go...
container/lxc/mock/mock-lxc.go:87: data, err := ioutil.ReadFile(configFile)
On 2014/03/11 02:24:13, axw wrote:
> There's utils.CopyFile, if you didn't know.

No I didn't. Using it now.

[axw, 2014-03-11 03:59:46]

On 2014/03/11 03:46:16, thumper wrote:
> Please take a look.
> 
> https://codereview.appspot.com/73300043/diff/1/container/lxc/lxc_test.go
> File container/lxc/lxc_test.go (right):
> 
>
https://codereview.appspot.com/73300043/diff/1/container/lxc/lxc_test.go#newc...
> container/lxc/lxc_test.go:179: name := string(instance.Id())
> On 2014/03/11 02:24:13, axw wrote:
> > It's not clear why this has changed. Has something caused the contents of
the
> > file to be different (apart from the lxc.start.auto)? I would think it's
> > preferable to match exactly if it's not too onerous.
> 
> Doing an exact match now.
> 
> In order to make the match easily, I have also added in the part where the
> mounting of the log dir is done after create.
> 
> https://codereview.appspot.com/73300043/diff/1/container/lxc/mock/mock-lxc.go
> File container/lxc/mock/mock-lxc.go (right):
> 
>
https://codereview.appspot.com/73300043/diff/1/container/lxc/mock/mock-lxc.go...
> container/lxc/mock/mock-lxc.go:87: data, err := ioutil.ReadFile(configFile)
> On 2014/03/11 02:24:13, axw wrote:
> > There's utils.CopyFile, if you didn't know.
> 
> No I didn't. Using it now.

LGTM, thanks