code review 7326053: misc/dashboard/builder: various cleanups

misc/dashboard/builder: various cleanups

* allow commit watcher to be disabled, useful for small slow builders who will never be the first to notice a commit.
* builders always update their local master working copy before cloning a specific revision.
* refactor hg repo operations into a new type, Repo.

[dave_cheney.net, 2013-02-20 09:07:18]

Hello adg@golang.org, shanemhansen@gmail.com, luitvd@gmail.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[adg, 2013-02-21 00:50:09]

LGTM

Nuts, I thought I had submitted https://codereview.appspot.com/7174046

After you submit I'll bring it up to date, and would you mind reviewing it?

https://codereview.appspot.com/7326053/diff/13001/misc/dashboard/builder/vcs.go
File misc/dashboard/builder/vcs.go (right):

https://codereview.appspot.com/7326053/diff/13001/misc/dashboard/builder/vcs....
misc/dashboard/builder/vcs.go:140: var logByHash = map[string]*HgLog{}
put this back beside the commitPoll method, which is the only thing that uses
this. otherwise it's hard to guess who uses it

[dave_cheney.net, 2013-02-21 02:12:29]

*** Submitted as https://code.google.com/p/go/source/detail?r=bfb45be43e2b ***

misc/dashboard/builder: various cleanups

* allow commit watcher to be disabled, useful for small slow builders who will
never be the first to notice a commit.
* builders always update their local master working copy before cloning a
specific revision.
* refactor hg repo operations into a new type, Repo.

R=adg, shanemhansen, luitvd
CC=golang-dev
https://codereview.appspot.com/7326053

https://codereview.appspot.com/7326053/diff/10001/misc/dashboard/builder/main.go
File misc/dashboard/builder/main.go (left):

https://codereview.appspot.com/7326053/diff/10001/misc/dashboard/builder/main...
misc/dashboard/builder/main.go:136: // Start commit watcher, and exit if that's
all we're doing.
can't actually get here, line 89 will always exit with usage() if there are no
builder names here.

[dave_cheney.net, 2013-02-21 02:13:15]

Done, please remerge 7174046

On Thu, Feb 21, 2013 at 11:50 AM,  <adg@golang.org> wrote:
> LGTM
>
> Nuts, I thought I had submitted https://codereview.appspot.com/7174046
>
> After you submit I'll bring it up to date, and would you mind reviewing
> it?
>
>
>
https://codereview.appspot.com/7326053/diff/13001/misc/dashboard/builder/vcs.go
> File misc/dashboard/builder/vcs.go (right):
>
>
https://codereview.appspot.com/7326053/diff/13001/misc/dashboard/builder/vcs....
> misc/dashboard/builder/vcs.go:140: var logByHash = map[string]*HgLog{}
> put this back beside the commitPoll method, which is the only thing that
> uses this. otherwise it's hard to guess who uses it
>
> https://codereview.appspot.com/7326053/