code review 7325043: net: add IPConn through Conn test

net: add IPConn through Conn test

Also refactors mock ICMP stuff.

[mikio, 2013-02-14 02:54:16]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-02-15 11:08:11]

I am a little concerned that the ICMP message is being sent without something
waiting to receive the reply, does this require loopback support from the OS ?

The same stylistic comments that apply to CL 7304091 may be applicable here if
you choose.

https://codereview.appspot.com/7325043/diff/5001/src/pkg/net/ipraw_test.go
File src/pkg/net/ipraw_test.go (right):

https://codereview.appspot.com/7325043/diff/5001/src/pkg/net/ipraw_test.go#ne...
src/pkg/net/ipraw_test.go:274: if msglen-4 > 0 {
i'd prefer msglen > 3 and below if that is possible

[mikio, 2013-02-16 03:36:06]

Hello golang-dev@googlegroups.com, dave@cheney.net (cc:
golang-dev@googlegroups.com),

Please take another look.

[mikio, 2013-02-16 03:38:06]

On 2013/02/15 11:08:11, dfc wrote:

> I am a little concerned that the ICMP message is being sent without something
> waiting to receive the reply, does this require loopback support from the OS ?

sure,  this test just talks with protocol stack inside kernel.

[mikio, 2013-02-16 03:38:20]

PTAL

https://codereview.appspot.com/7325043/diff/5001/src/pkg/net/ipraw_test.go
File src/pkg/net/ipraw_test.go (right):

https://codereview.appspot.com/7325043/diff/5001/src/pkg/net/ipraw_test.go#ne...
src/pkg/net/ipraw_test.go:274: if msglen-4 > 0 {
On 2013/02/15 11:08:11, dfc wrote:
> i'd prefer msglen > 3 and below if that is possible

Done.

[dave_cheney.net, 2013-02-16 03:48:25]

LGTM. Please wait for a second opinion

[rsc, 2013-02-16 03:49:53]

LGTM

I didn't look very closely. If you're both happy, I'm happy.

[mikio, 2013-02-16 03:55:48]

*** Submitted as https://code.google.com/p/go/source/detail?r=3836bcbafa69 ***

net: add IPConn through Conn test

Also refactors mock ICMP stuff.

R=dave, rsc
CC=golang-dev
https://codereview.appspot.com/7325043