Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(171)

Issue 7324056: code review 7324056: syscall: don't make //sys lines be doc comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by bradfitz
Modified:
12 years, 4 months ago
Reviewers:
CC:
golang-dev, minux1, rsc
Visibility:
Public.

Description

syscall: don't make //sys lines be doc comments Cleans up godoc and makes it consistent. (some had it, some didn't) This still keeps the information there, though, for people looking at the source directly.

Patch Set 1 #

Patch Set 2 : diff -r 9ab99f5d4a82 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9ab99f5d4a82 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 663043612e41 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/pkg/syscall/syscall_bsd.go View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/syscall_linux.go View 1 9 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 4 months ago (2013-02-14 18:20:39 UTC) #1
minux1
Hi brad, while you're at it, do you mind also piggyback this patch in your ...
12 years, 4 months ago (2013-02-14 18:27:02 UTC) #2
rsc
LGTM with minux's addition
12 years, 4 months ago (2013-02-14 18:56:43 UTC) #3
bradfitz
12 years, 4 months ago (2013-02-14 19:24:01 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=efe6fc100ede ***

syscall: don't make //sys lines be doc comments

Cleans up godoc and makes it consistent. (some had it, some
didn't)

This still keeps the information there, though, for people
looking at the source directly.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://codereview.appspot.com/7324056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b