Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(321)

Issue 7324054: rpc, state/api: consistent errors.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by rog
Modified:
12 years, 5 months ago
Reviewers:
fwereade, mp+148468
Visibility:
Public.

Description

rpc, state/api: consistent errors. It helps to close the right thing, and there's probably no point in sending a message to the server when it's about to be closed. Not easy to test, unfortunately, as triggering the different error message involves catching the input goroutine in just the right place. https://code.launchpad.net/~rogpeppe/juju-core/216-rpc-consistent-close-error/+merge/148468 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : rpc, state/api: consistent errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M rpc/client.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/client.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
rog
*** Submitted: rpc, state/api: consistent errors. It helps to close the right thing, and there's ...
12 years, 5 months ago (2013-02-14 16:05:59 UTC) #1
fwereade
12 years, 5 months ago (2013-02-14 16:08:18 UTC) #2
retroactive LGTM, assuming it's tested
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b