Issue 7324046: rpc: don't hang tests on failure

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7324046: rpc: don't hang tests on failure

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by rog

Modified:
11 years, 2 months ago

Reviewers:
dimitern, mp+148162, fwereade

Visibility:
Public.

Description

rpc: don't hang tests on failure As suggested in previous CL. Also delete Accept method, also suggested earlier and not done. https://code.launchpad.net/~rogpeppe/juju-core/213-rpc-test-timeouts/+merge/148162 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : rpc: don't hang tests on failure #

Total comments: 2

Patch Set 3 : rpc: don't hang tests on failure #

Patch Set 4 : rpc: don't hang tests on failure #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -54 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	rpc/rpc_test.go	View		4 chunks	+34 lines, -15 lines	0 comments	Download
M	rpc/server.go	View	1 2	2 chunks	+0 lines, -39 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

fwereade

LGTM, one suggestion https://codereview.appspot.com/7324046/diff/2001/rpc/rpc_test.go File rpc/rpc_test.go (right): https://codereview.appspot.com/7324046/diff/2001/rpc/rpc_test.go#newcode277 rpc/rpc_test.go:277: case <-time.After(3 * time.Second): Can we ...

11 years, 2 months ago (2013-02-13 12:56:35 UTC) #3

rog

11 years, 2 months ago (2013-02-13 15:54:44 UTC) #5

*** Submitted:

rpc: don't hang tests on failure

As suggested in previous CL.
Also delete Accept method, also suggested earlier
and not done.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/7324046

https://codereview.appspot.com/7324046/diff/2001/rpc/rpc_test.go
File rpc/rpc_test.go (right):

https://codereview.appspot.com/7324046/diff/2001/rpc/rpc_test.go#newcode277
rpc/rpc_test.go:277: case <-time.After(3 * time.Second):
On 2013/02/13 12:56:35, fwereade wrote:
> Can we reasonably drop this to, say, half a second?

why bother? the timeout only happens on test failure, and in that case 3 seconds
isn't an issue.

Expand All Messages | Collapse All Messages