Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4017)

Issue 7323074: Use default keyboard layout by default (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by maiku.fabian
Modified:
11 years, 2 months ago
Reviewers:
Daiki Ueno
CC:
Daiki Ueno
Base URL:
https://github.com/ibus/ibus-m17n@master
Visibility:
Public.

Description

Use default keyboard layout by default Most ibus-m17n engines should not change the keyboard layout Unless there is a good reason to change the keyboard layout, most ibus-m17n engines should just keep the current keyboard layout. Currently, selecting engines like latn-post, latn-pre, da-post, ... switches to US English keyboard layout. But this is not nice because these input methods can be used with almost any keyboard layout (as long as it can be used to input ASCII). For example, a user who uses German keyboard layout and wants to use the latn-post input method to type other Latin based languages, will certainly want to keep the German layout while using latn-post. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/m17nutil.c View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Daiki Ueno
lgtm, thanks. I've just created 1.4.y branch in the repo, so the version check should ...
11 years, 2 months ago (2013-02-20 01:57:01 UTC) #1
maiku.fabian
11 years, 2 months ago (2013-02-20 05:36:42 UTC) #2
On 2013/02/20 01:57:01, Daiki Ueno wrote:
> lgtm, thanks.
> 
> I've just created 1.4.y branch in the repo, so the version check should be no
> longer needed (sorry for the confusion, Mike!)

Ah, OK, thank you!

I see you have comitted already, so this can be closed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b