Issue 7322068: code review 7322068: runtime: instrument slicebytetostring for race detection

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7322068: code review 7322068: runtime: instrument slicebytetostring for race detection (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by dvyukov

Modified:
12 years, 4 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

runtime: instrument slicebytetostring for race detection

Patch Set 1 #

Patch Set 2 : diff -r 7cb3730e3f37 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 7cb3730e3f37 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 7cb3730e3f37 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r d4024b084e0c https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -0 lines)			Patch
	M	src/pkg/runtime/race/testdata/slice_test.go	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download
	M	src/pkg/runtime/string.goc	View	1 2	3 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years, 4 months ago (2013-02-13 08:23:24 UTC) #1

dvyukov

12 years, 4 months ago (2013-02-13 14:31:26 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=77681607ee14 ***

runtime: instrument slicebytetostring for race detection

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7322068

Expand All Messages | Collapse All Messages