Issue 7317050: worker/uniter/jujuc: log callbacks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7317050: worker/uniter/jujuc: log callbacks

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by rog

Modified:
11 years, 2 months ago

Reviewers:
mp+149014, jameinel, fwereade

Visibility:
Public.

Description

worker/uniter/jujuc: log callbacks It's useful to see the actual commands that a hook makes back to the uniter when debugging. https://code.launchpad.net/~rogpeppe/juju-core/220-uniter-log-hook-callbacks/+merge/149014 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : worker/uniter/jujuc: log callbacks #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	worker/uniter/jujuc/server.go	View		2 chunks	+3 lines, -0 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

*** Submitted: worker/uniter/jujuc: log callbacks It's useful to see the actual commands that a hook ...

11 years, 2 months ago (2013-02-18 11:40:19 UTC) #2

jameinel

LGTM https://codereview.appspot.com/7317050/diff/3001/worker/uniter/jujuc/server.go File worker/uniter/jujuc/server.go (right): https://codereview.appspot.com/7317050/diff/3001/worker/uniter/jujuc/server.go#newcode98 worker/uniter/jujuc/server.go:98: log.Printf("worker/uniter/jujuc: hook context id %q; dir %q", req.ContextId, ...

11 years, 2 months ago (2013-02-18 12:34:19 UTC) #3

rog

11 years, 2 months ago (2013-02-18 15:53:06 UTC) #4

https://codereview.appspot.com/7317050/diff/3001/worker/uniter/jujuc/server.go
File worker/uniter/jujuc/server.go (right):

https://codereview.appspot.com/7317050/diff/3001/worker/uniter/jujuc/server.g...
worker/uniter/jujuc/server.go:98: log.Printf("worker/uniter/jujuc: hook context
id %q; dir %q", req.ContextId, req.Dir)
On 2013/02/18 12:34:19, jameinel wrote:
> Should this be log.Printf or log.Debugf?
> Otherwise LGTM

i'm not sure. thoughts anyone?

there was one thing wrong with this that we all missed - this isn't "running
hook" - it's running a hook tool. will fix in a subsequent CL.

Expand All Messages | Collapse All Messages