Issue 7317047: code review 7317047: runtime/pprof: adjust reported line numbers to show cal...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7317047: code review 7317047: runtime/pprof: adjust reported line numbers to show cal... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by rsc

Modified:
12 years, 4 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

runtime/pprof: adjust reported line numbers to show call sites This is the same logic used in the standard tracebacks. The caller pc is the pc after the call, so except in the fake "call" caused by a panic, back up the pc enough that the lookup will use the previous instruction. Fixes issue 4150. Fixes issue 4151.

Patch Set 1 #

Patch Set 2 : diff -r 90e25d15bc1c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 90e25d15bc1c https://code.google.com/p/go/ #

Patch Set 4 : diff -r e7b206201e2a https://go.googlecode.com/hg/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	src/pkg/runtime/pprof/pprof.go	View	1	1 chunk	+15 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 4 months ago (2013-02-15 05:19:34 UTC) #1

rsc

12 years, 4 months ago (2013-02-15 19:27:19 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=eb5703eead92 ***

runtime/pprof: adjust reported line numbers to show call sites

This is the same logic used in the standard tracebacks.
The caller pc is the pc after the call, so except in the
fake "call" caused by a panic, back up the pc enough
that the lookup will use the previous instruction.

Fixes issue 4150.
Fixes issue 4151.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7317047

Expand All Messages | Collapse All Messages