Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1719)

Issue 7317046: Ghost service minors for UX check

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by matthew.scott
Modified:
11 years, 2 months ago
Reviewers:
mp+148574
Visibility:
Public.

Description

Ghost service minors for UX check Per Nick: The ghost service name should update on blur from the service name field (bug 1125506). Per Kapil: buttons should be disabled after clicking confirm deploy, or a double-click can lead to an error (bug 1124414). https://code.launchpad.net/~makyo/juju-gui/ghost-minors-1125506-1124414/+merge/148574 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Ghost service minors for UX check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/charm-panel.js View 4 chunks +21 lines, -1 line 0 comments Download
M test/test_charm_panel.js View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4
matthew.scott
Please take a look.
11 years, 2 months ago (2013-02-14 23:30:18 UTC) #1
bac
Looks good to land.
11 years, 2 months ago (2013-02-15 15:53:19 UTC) #2
benji
Looks good.
11 years, 2 months ago (2013-02-15 16:43:21 UTC) #3
matthew.scott
11 years, 2 months ago (2013-02-15 17:00:08 UTC) #4
*** Submitted:

Ghost service minors for UX check

Per Nick: The ghost service name should update on blur from the service name
field (bug 1125506).  Per Kapil: buttons should be disabled after clicking
confirm deploy, or a double-click can lead to an error (bug 1124414).

R=bac, benji
CC=
https://codereview.appspot.com/7317046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b