Issue 7314114: code review 7314114: fmt: fix width for nil values

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7314114: code review 7314114: fmt: fix width for nil values (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by r

Modified:
12 years ago

Reviewers:

CC:
r, adg, golang-dev

Visibility:
Public.

Description

fmt: fix width for nil values Apply width when using Printf with nil values. Fixes issue 4772.

Patch Set 1 : diff -r 0adf91947752 https://code.google.com/p/go #

Patch Set 2 : diff -r 0adf91947752 https://code.google.com/p/go #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/pkg/fmt/fmt_test.go	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	src/pkg/fmt/print.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

r_oktett.se

Hello golang-dev@googlegroups.com (cc: iant@golang.org, r@golang.org, rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go

12 years ago (2013-02-16 20:23:39 UTC) #1

12 years ago (2013-02-20 22:30:17 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=ac7cf6ff2de8 ***

fmt: fix width for nil values

Apply width when using Printf with nil values.
Fixes issue 4772.

R=r, adg
CC=golang-dev
https://codereview.appspot.com/7314114

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages