Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1302)

Issue 7314102: Allow multiple mongodb instances

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by abentley-home
Modified:
11 years, 2 months ago
Reviewers:
j.c.sackett, mp+148552
Visibility:
Public.

Description

Allow multiple mongodb instances Change functionality of write_config so that it directly interrogates the environment to determine the juju hosts, instead of accepting commandline parameters or reading previous config. Use mongo.url setting instead of host/port, and stop setting session.secret (it's now unused). write_config moves into scripts/ partly for cleanliness and partly to access charmsupport. With this change to write_config, config-changed now handles db relation changes as well as setting changes, so invoke it in every db relation hook (except join, since -changed will follow join). database-relation-changed is now essentially a wrapper to ensure that ingest is run when a database becomes available. Flatten the refresh function back into the body of config-changed, since it would be invoked unconditionally. Delete ~webops_deploy/charmworld on install if present, since it may contain incorrect or invalid config data. https://code.launchpad.net/~abentley/charms/precise/charmworld/multi-mongo/+merge/148552 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -80 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M common View 1 chunk +7 lines, -2 lines 0 comments Download
M hooks/config-changed View 3 chunks +17 lines, -17 lines 0 comments Download
M hooks/database-relation-broken View 1 chunk +0 lines, -7 lines 0 comments Download
M hooks/database-relation-changed View 1 chunk +14 lines, -19 lines 0 comments Download
M hooks/install View 1 chunk +1 line, -0 lines 0 comments Download
M hooks/upgrade-charm View 1 chunk +5 lines, -8 lines 0 comments Download
M production_overrides.ini View 1 chunk +0 lines, -1 line 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M scripts/write_config.py View 2 chunks +44 lines, -25 lines 0 comments Download

Messages

Total messages: 2
abentley-home
Please take a look.
11 years, 2 months ago (2013-02-14 20:27:24 UTC) #1
j.c.sackett
11 years, 2 months ago (2013-02-14 21:11:33 UTC) #2
On 2013/02/14 20:27:24, abentley wrote:
> Please take a look.

lgtm.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b