Issue 7314097: code review 7314097: net: delete TestDialTimeoutHandleLeak

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7314097: code review 7314097: net: delete TestDialTimeoutHandleLeak (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by brainman

Modified:
12 years, 4 months ago

Reviewers:

CC:
golang-dev, bradfitz, mikio

Visibility:
Public.

Description

net: delete TestDialTimeoutHandleLeak It is too flaky. Tried to make it more reliable, but that affects other tests (they run too long), because we do unusual things here, like attempting to connect to non-existing address and interrupt.

Patch Set 1 #

Patch Set 2 : diff -r 31065f4dbca5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 31065f4dbca5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r fdf84e3a0efe https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 90e25d15bc1c https://go.googlecode.com/hg/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -73 lines)			Patch
	R	src/pkg/net/dial_windows_test.go	View	1 2 3	1 chunk	+0 lines, -73 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 4 months ago (2013-02-14 03:53:48 UTC) #1

brainman

I saw one false positive on user report http://goo.gl/EgV05 (see attached log file). But it ...

12 years, 4 months ago (2013-02-14 03:54:13 UTC) #2

brainman

Please, do not review yet. Now suddenly TestShutdown takes ~10s to run. I need to ...

12 years, 4 months ago (2013-02-14 06:30:24 UTC) #3

brainman

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 4 months ago (2013-02-15 02:16:42 UTC) #4

bradfitz

LGTM On Thu, Feb 14, 2013 at 6:16 PM, <alex.brainman@gmail.com> wrote: > Hello golang-dev@googlegroups.com (cc: ...

12 years, 4 months ago (2013-02-15 02:29:05 UTC) #5

brainman

12 years, 4 months ago (2013-02-15 04:52:25 UTC) #7

*** Submitted as https://code.google.com/p/go/source/detail?r=a96415ec9a92 ***

net: delete TestDialTimeoutHandleLeak

It is too flaky. Tried to make it more reliable,
but that affects other tests (they run too long),
because we do unusual things here, like attempting
to connect to non-existing address and interrupt.

R=golang-dev, bradfitz, mikioh.mikioh
CC=golang-dev
https://codereview.appspot.com/7314097

Expand All Messages | Collapse All Messages