Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(62)

Issue 7314082: Add a loading messages and animation.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by benji
Modified:
7 years ago
Reviewers:
mp+147761
Visibility:
Public.

Description

Add a loading messages and animation. https://code.launchpad.net/~benji/juju-gui/bug-1110515-loading-message/+merge/148243 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add a loading animation. #

Total comments: 7

Patch Set 3 : Add a loading animation. #

Total comments: 6

Patch Set 4 : Add a loading animation. #

Patch Set 5 : Add a loading messages and animation. #

Patch Set 6 : Add a loading messages and animation. #

Patch Set 7 : Add a loading messages and animation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -24 lines) Patch
M Makefile View 1 3 chunks +2 lines, -1 line 0 comments Download
A [revision details] View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
A app/assets/images/non-sprites/loading-spinner.gif View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/javascripts/spin.min.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M app/index.html View 1 2 3 4 8 chunks +79 lines, -11 lines 0 comments Download
M app/views/login.js View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/views/stylesheet.less View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M test/index.html View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M test/test_startup.js.bottom View 1 2 3 4 4 chunks +31 lines, -2 lines 0 comments Download
M test/test_startup.js.top View 1 2 3 4 5 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 9
gary.poster
Looks like good progress. As I mentioned on IRC, the JS is still the right ...
7 years ago (2013-02-12 13:46:39 UTC) #1
benji
Please take a look.
7 years ago (2013-02-12 21:37:34 UTC) #2
benji
Please take a look.
7 years ago (2013-02-12 21:52:54 UTC) #3
gary.poster
These comments were from an earlier version. not much to them. looking at the newer ...
7 years ago (2013-02-12 21:55:40 UTC) #4
bac
Looks good except for some typos. Thanks! https://codereview.appspot.com/7314082/diff/4001/test/test_startup.js.bottom File test/test_startup.js.bottom (right): https://codereview.appspot.com/7314082/diff/4001/test/test_startup.js.bottom#newcode4 test/test_startup.js.bottom:4: // The ...
7 years ago (2013-02-12 21:56:31 UTC) #5
gary.poster
Very nice Benji. Thank you. Especially good job with the testing in this and the ...
7 years ago (2013-02-12 23:08:08 UTC) #6
benji
> I would strongly prefer that you follow up with the change I request > ...
7 years ago (2013-02-13 16:39:23 UTC) #7
benji
*** Submitted: Add a loading messages and animation. R=gary.poster, bac CC= https://codereview.appspot.com/7314082
7 years ago (2013-02-13 16:46:28 UTC) #8
benji
7 years ago (2013-02-13 17:11:28 UTC) #9
*** Submitted:

Add a loading messages and animation.

R=
CC=
https://codereview.appspot.com/7314082
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b