Issue 7313069: code review 7313069: spec: document fp rounding during explicit constant con...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7313069: code review 7313069: spec: document fp rounding during explicit constant con... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by rsc

Modified:
12 years, 4 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

spec: document fp rounding during explicit constant conversion The gc compilers already behave this way. It was an explicit decision during the very long constant design discussions, but it appears not to have made it into the spec. Fixes issue 4398.

Patch Set 1 #

Patch Set 2 : diff -r e8eb2c8d5ce1 https://code.google.com/p/go/ #

Patch Set 3 : diff -r e8eb2c8d5ce1 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r a44171137af8 https://code.google.com/p/go/ #

Patch Set 5 : diff -r e5febb4359bc https://code.google.com/p/go/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	doc/go_spec.html	View	1 2 3	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 4 months ago (2013-02-09 19:42:54 UTC) #1

https://codereview.appspot.com/7313069/diff/4001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/7313069/diff/4001/doc/go_spec.html#newcode3476 doc/go_spec.html:3476: <li> x is a floating point constant, T is ...

12 years, 4 months ago (2013-02-09 21:19:28 UTC) #2

rsc

PTAL https://codereview.appspot.com/7313069/diff/4001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/7313069/diff/4001/doc/go_spec.html#newcode3476 doc/go_spec.html:3476: <li> I added: The constant <code>T(x)</code> is the ...

12 years, 4 months ago (2013-02-09 22:54:17 UTC) #3

rsc

12 years, 4 months ago (2013-02-11 12:47:45 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=2044cd3dc3b4 ***

spec: document fp rounding during explicit constant conversion

The gc compilers already behave this way. It was an explicit
decision during the very long constant design discussions,
but it appears not to have made it into the spec.

Fixes issue 4398.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7313069

Expand All Messages | Collapse All Messages