Issue 7313054: http Issue 186: Rename dependencies files to match package names

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7313054: http Issue 186: Rename dependencies files to match package names (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by ngmiceli

Modified:
11 years, 2 months ago

Reviewers:
yanivi

Base URL:
https://code.google.com/p/google-http-java-client/

Visibility:
Public.

More Reviews

Description

http Issue 186: Rename dependencies files to match package names

Patch Set 1 #

Total comments: 1

Patch Set 2 : Minor #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
M	google-http-client-assembly/dependencies/google-http-client-android-dependencies.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	google-http-client-assembly/dependencies/google-http-client-appengine-dependencies.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	google-http-client-assembly/dependencies/google-http-client-dependencies.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	google-http-client-assembly/dependencies/google-http-client-gson-dependencies.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	google-http-client-assembly/dependencies/google-http-client-jackson-dependencies.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	google-http-client-assembly/dependencies/google-http-client-jackson2-dependencies.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	google-http-client-assembly/dependencies/google-http-client-protobuf-dependencies.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	google-http-client-assembly/readme.html	View	1	1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

yanivi

11 years, 2 months ago (2013-02-11 16:57:16 UTC) #2

LGTM

https://codereview.appspot.com/7313054/diff/1/google-http-client-assembly/rea...
File google-http-client-assembly/readme.html (right):

https://codereview.appspot.com/7313054/diff/1/google-http-client-assembly/rea...
google-http-client-assembly/readme.html:34: <li>google-http-client: <a
href='dependencies/google-http-client-dependencies.html'>dependencies.html</a></li>
please also change the text part of the link, i.e.
<a
href='dependencies/google-http-client-dependencies.html'>google-http-client-dependencies.html</a>

Expand All Messages | Collapse All Messages