Issue 7312099: state: fix validity checks in AuthEntity

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7312099: state: fix validity checks in AuthEntity

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by fwereade

Modified:
12 years, 5 months ago

Reviewers:
mp+148385, rog

Visibility:
Public.

Description

state: fix validity checks in AuthEntity https://code.launchpad.net/~fwereade/juju-core/fix-unit-auth-entity/+merge/148385 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : state: fix unit names in AuthEntity #

Patch Set 3 : state: fix unit names in AuthEntity #

Patch Set 4 : state: fix unit names in AuthEntity #

Patch Set 5 : state: fix validity checks in AuthEntity #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -3 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/state.go	View	1 2 3	1 chunk	+12 lines, -1 line	0 comments	Download
M	state/state_test.go	View	1 2 3	3 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

rog

LGTM with one thought below. this was my mistake, sorry about that. https://codereview.appspot.com/7312099/diff/1/state/state.go File state/state.go ...

12 years, 5 months ago (2013-02-14 08:44:58 UTC) #2

rog

On 2013/02/14 09:08:53, fwereade wrote: > Please take a look. LGTM

12 years, 5 months ago (2013-02-14 09:11:17 UTC) #6

fwereade

12 years, 5 months ago (2013-02-14 09:13:00 UTC) #7

*** Submitted:

state: fix validity checks in AuthEntity

R=rog
CC=
https://codereview.appspot.com/7312099

Expand All Messages | Collapse All Messages