Issue 7312090: code review 7312090: exp/ssa: add Instruction.Operands and Value.Referrers m...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7312090: code review 7312090: exp/ssa: add Instruction.Operands and Value.Referrers m... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by adonovan

Modified:
12 years, 4 months ago

Reviewers:

CC:
iant, gri, golang-dev

Visibility:
Public.

Description

exp/ssa: add Instruction.Operands and Value.Referrers methods. Operands returns the SSA values used by an instruction. Referrers returns the SSA instructions that use a value, for some values. These will be used for SSA renaming, to follow.

Patch Set 1 #

Patch Set 2 : diff -r 86c70475d48f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 86c70475d48f https://code.google.com/p/go/ #

Patch Set 4 : diff -r 86c70475d48f https://code.google.com/p/go/ #

Patch Set 5 : diff -r 86c70475d48f https://code.google.com/p/go/ #

Patch Set 6 : diff -r 86c70475d48f https://code.google.com/p/go/ #

Patch Set 7 : diff -r 3b702853541b https://code.google.com/p/go/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+226 lines, -34 lines)			Patch
M	src/pkg/exp/ssa/func.go	View	1 2 3 4 5 6	2 chunks	+16 lines, -1 line	0 comments	Download
M	src/pkg/exp/ssa/interp/interp.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/ssa/literal.go	View	1 2 3 4 5 6	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/exp/ssa/ssa.go	View	1 2 3 4 5 6	10 chunks	+205 lines, -32 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello iant@golang.org, gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 4 months ago (2013-02-12 21:47:13 UTC) #1

adonovan

12 years, 4 months ago (2013-02-13 05:15:11 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=ff721d07344a ***

exp/ssa: add Instruction.Operands and Value.Referrers methods.

Operands returns the SSA values used by an instruction.
Referrers returns the SSA instructions that use a value, for
some values.  These will be used for SSA renaming, to follow.

R=iant, gri
CC=golang-dev
https://codereview.appspot.com/7312090

Expand All Messages | Collapse All Messages