Issue 7312078: Store session secret in database.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7312078: Store session secret in database.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by abentley-home

Modified:
11 years, 2 months ago

Reviewers:
hazmat, mp+147746

Visibility:
Public.

Description

Store session secret in database. Use the database to hold the session secret, so that the data is shared among all instances. hazmat suggested using findAndModify, and this would have required an insert so that there was a record to find. This implementation simply uses insert with a specified _id. Insert fails if a document already exists with that id, so the secret is stored only on the first attempt. https://code.launchpad.net/~abentley/charmworld/multi-charmworld/+merge/147746 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -2 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmworld/__init__.py	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	charmworld/models.py	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	charmworld/test_models.py	View	2 chunks	+24 lines, -0 lines	0 comments	Download
M	default.ini	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hazmat

11 years, 2 months ago (2013-02-11 20:54:40 UTC) #2

On 2013/02/11 19:12:18, abentley wrote:
> Please take a look.

lgtm, thanks

Expand All Messages | Collapse All Messages